Patterns: disable editing of synced patterns in post editor unless children have connected content set #56703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the pattern block mode
…efault with partial syncing
glendaviesnz
added
[Type] Enhancement
|
Size Change: +446 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in c37ab47. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7054943323
|
|
Closing in favour of #57036 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A draft alternative to #56574
What?
This version edits the source pattern in place instead of redirecting to the editor
Locks pattern editing in the post editor to only child blocks that have had content connections set.
N.B. This PR changes the paradigm for editing synced patterns in the editor and moves the editing of a pattern's content that causes global changes to the site editor or the wp-admin pattern editing interfaces (details of why below).
Why?
As part of the work on allowing partial editing of synced patterns we want to disable full editing of the synced pattern entities by default in the post editor.
This will make it easier to indicate to users when they are editing just a section of the pattern for that instance of the pattern only, versus editing the global source pattern instance.
This would also fix #54442 as the edit button only shows if the user has permission to update the pattern. It also fixes #32353
How?
Sets each of the patterns innerBlocks edit mode to
disabledusingsetBlockEditingModeunless the block connected attributes are set in which case the block is set tocontentOnly.Important note - limiting editing to
contentOnlyin the post editor is 🤞 just the starting point. We are keeping it restricted to contentOnly to keep things simple while we set up the initial APIs for implementing partial syncing. The hope is that we can later extend it out to things like innerBlocks, limited block style attributes, etc. when/if the complexities around doing so are resolved.Testing Instructions
Edit parent patternbutton in the block toolbar unlocks the innerBlocks for full editing, andStop editing parent patternlocks the innerBlocks againEdit parent patternbutton does not display if the user does not have edit permission for the given patterncontentOnly. Also check that theContentpanel appears in right inspector panel when block or nested content selected.Screenshots or screencast
edit-parent.mp4