Post Editor: Rely on the editor store for the template mode state #56716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Code Quality
youknowriad
requested review from
ramonjd,
tellthemachines,
andrewserong,
ntsekouras and
fabiankaegy
youknowriad
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar and
ndiego
as code owners
|
Size Change: +134 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
ramonjd
reviewed
Dec 3, 2023
|
|
||
| export default function WelcomeGuideMenuItem() { | ||
| const isTemplateMode = useSelect( | ||
| ( select ) => select( editPostStore ).isEditingTemplate(), | ||
| ( select ) => select( editorStore ).getRenderingMode() !== 'post-only', |
There was a problem hiding this comment.
Just checking, does this check match the previous isEditingTemplate()? I noticed it will included template-locked - where the post is editable but the template locked.
There was a problem hiding this comment.
In the post editor, there were only two modes (not like the site editor), so yeah, it will have the same effect for now.
Base automatically changed from
update/sync-post-site-editor-post-only-mode
to
trunk
December 5, 2023 07:10
youknowriad
force-pushed
the
update/template-mode-state
branch
from
0d82a19
to
6393850
Compare
|
Any approvals here :) |
|
Flaky tests detected in 6393850. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7097383703
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #52632
Follow-up to #56671
What?
This PR updates the post editor, to avoid relying on its own store for the "template mode" state, instead it uses the "editor" package rendering modes directly similarly to the site editor.
Why?
This PR is a preparation work before unifying the UI to switch modes... between post and site editors. The UI component will be in the editor store and it will directly update its state.
Testing Instructions
1- Check the post editor and its "template mode" (edit template link from the "template" panel on the settings sidebar)