Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font Library: add font family and font face preview keys to schema #56793

Merged
merged 4 commits into from
Dec 5, 2023

Conversation

matiasbenedetto
Copy link
Contributor

@matiasbenedetto matiasbenedetto commented Dec 5, 2023

What?

Font Library: add font family and font face preview keys to schema.
The preview property is optional and it's used to store a reference to a preview of the font asset.

Example:
In the Font Library default font collection is used to store an image preview in SVG format.

Why?

To avoid using a non-documented key preview.
To avoid wiping the preview data during sanitization.

How?

Add to theme.json schema to document this key.
Add to PHP sanitization schema to avoid the preview data being removed by the sanitization process.

Testing Instructions

  • Install a font from the Google Fonts collection.
  • Check that the font preview data is not removed when saved to the database.

Copy link

github-actions bot commented Dec 5, 2023

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ lib/class-wp-theme-json-gutenberg.php

@matiasbenedetto matiasbenedetto added the [Type] Bug An existing feature does not function as intended label Dec 5, 2023
Copy link

github-actions bot commented Dec 5, 2023

Flaky tests detected in 2616cfc.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7106910502
📝 Reported issues:

schemas/json/theme.json Outdated Show resolved Hide resolved
Copy link
Contributor

@jffng jffng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs need to be rebuilt (npm run docs:build), other than that and one small comment, LGTM.

matiasbenedetto and others added 2 commits December 5, 2023 15:37
Co-authored-by: Jeff Ong <jonger4@gmail.com>
@matiasbenedetto
Copy link
Contributor Author

The docs need to be rebuilt (npm run docs:build), other than that and one small comment, LGTM.

Thanks for the review. Docs updated :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants