DataViews: Remove TanStack #56873
Merged
DataViews: Remove TanStack #56873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Code Quality
ntsekouras
requested review from
mcsf,
youknowriad,
oandregal and
jorgefilipecosta
|
Size Change: -14.4 kB (-1%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 2e99941. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7131959547
|
|
I enabled the New admin views experiment to test. For template and pages I tested:
All work as expected. ✅ ✅ ✅ ✅ Sorry if you already know about this: There was one peculiarity I noticed on the templates data view ( 2023-12-08.12.51.37.mp4React profiler isn't working for me but Chrome points to a bunch of 
Switching views on pages is much snappier so I think it's the TemplatePreview component (I returned This is also on trunk, so not a blocker for this PR. |
|
Thanks for the thorough testing @ramonjd!
Yes, that's because of the templates preview field that is enabled when switching to |
ellatrix
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes the TanStack library that was being used in
tableview. That library was initially included when the sole supported view was thetableview and it seems it doesn't provides much value at this stage.The reasons are multiple and I'll mention a few:
maybecould help us a bit, like the reordering of fields.If in the future we could re evaluate if we need way more advanced table features.
Testing Instructions