Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dimensions: Add Aspect Ratio block support #56897

Merged
merged 14 commits into from
Jan 24, 2024
Merged

Dimensions: Add Aspect Ratio block support #56897

merged 14 commits into from
Jan 24, 2024

Commits on Jan 17, 2024

  1. Try: Dimensions Aspect Ratio block support

    @andrewserong
    andrewserong committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    15caba6 View commit details
    Browse the repository at this point in the history

  2. Try server-rendering output

    @andrewserong
    andrewserong committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    280dda5 View commit details
    Browse the repository at this point in the history

  3. Try outputting has-aspect-ratio classname

    @andrewserong
    andrewserong committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    5008b52 View commit details
    Browse the repository at this point in the history

  4. Ensure block support is checked properly

    @andrewserong
    andrewserong committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    2748fd0 View commit details
    Browse the repository at this point in the history

  5. Try adding global styles support

    @andrewserong
    andrewserong committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    aed99ad View commit details
    Browse the repository at this point in the history

  6. Update docs, add appropriate checks

    @andrewserong
    andrewserong committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    d1ce660 View commit details
    Browse the repository at this point in the history

  7. Try unsetting minHeight

    @andrewserong
    andrewserong committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    176860a View commit details
    Browse the repository at this point in the history

  8. Try unsetting min-height when applying aspect ratio and vice versa

    @andrewserong
    andrewserong committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    bbc6868 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. Allow Cover block to expand when the content extends beyond the bound… 

    …aries of the aspect-ratio
    @andrewserong
    andrewserong committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    96daf32 View commit details
    Browse the repository at this point in the history

  2. Hide cover block resize handle when aspect ratio is set, clear aspect… 

    … ratio when updating cover block min height
    @andrewserong
    andrewserong committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    051bb7f View commit details
    Browse the repository at this point in the history

  3. Clear aspect-ratio if minHeight is set on the site frontend

    @andrewserong
    andrewserong committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    ef7149d View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. Attempt to get unset rules playing nicely in the editor with global s… 

    …tyles
    @andrewserong
    andrewserong committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    2c9107d View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. Hide aspectRatio control from global styles for the group block

    @andrewserong
    andrewserong committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    39873bf View commit details
    Browse the repository at this point in the history

  2. Skip output of has-aspect-ratio if value isn't set

    @andrewserong
    andrewserong committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    7e14457 View commit details
    Browse the repository at this point in the history