Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PHP linter failing #56905

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Fix PHP linter failing #56905

merged 1 commit into from
Dec 8, 2023

Conversation

ellatrix
Copy link
Member

@ellatrix ellatrix commented Dec 8, 2023

What?

For some reason this suddenly started failing on PRs.

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

@ellatrix ellatrix added the [Type] Code Quality Issues or PRs that relate to code quality label Dec 8, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 8, 2023

Flaky tests detected in dd7da11.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7142572715
📝 Reported issues:

@ellatrix ellatrix enabled auto-merge (squash) December 8, 2023 14:50
@ellatrix ellatrix merged commit 46ea0ff into trunk Dec 8, 2023
56 checks passed
@ellatrix ellatrix deleted the fix/php-linter-complaining branch December 8, 2023 15:00
@github-actions github-actions bot added this to the Gutenberg 17.3 milestone Dec 8, 2023
mikachan pushed a commit that referenced this pull request Jan 3, 2024
@ellatrix @mikachan
Fix PHP linter failing (#56905)
5a0d979
mikachan pushed a commit that referenced this pull request Jan 5, 2024
@ellatrix @mikachan
Fix PHP linter failing (#56905)
32fe455
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciampo ciampo ciampo approved these changes

@ntwb ntwb Awaiting requested review from ntwb ntwb is a code owner

@nerrad nerrad Awaiting requested review from nerrad nerrad is a code owner

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees
No one assigned
Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 17.3
Development

Successfully merging this pull request may close these issues.
2 participants
@ellatrix @ciampo