-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update Image block failed upload visuals #56937
feat: Update Image block failed upload visuals #56937
Commits on Dec 14, 2023
-
refactor: Rename
useIsConnected
touseNetworkConnectivity
Attempt to better communicate the Hook intent.
Configuration menu - View commit details
-
Copy full SHA for 62191f5 - Browse repository at this point
Copy the full SHA 62191f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1af5f0e - Browse repository at this point
Copy the full SHA 1af5f0eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 25d141a - Browse repository at this point
Copy the full SHA 25d141aView commit details -
Configuration menu - View commit details
-
Copy full SHA for ddc08b8 - Browse repository at this point
Copy the full SHA ddc08b8View commit details -
fix: Optimistically presume network connectivity
Prior to making the asynchronous request to the host app across the bridge, it is a better UX to presume network connectivity is present rather than displaying network connectivity messages briefly.
Configuration menu - View commit details
-
Copy full SHA for f7bccf5 - Browse repository at this point
Copy the full SHA f7bccf5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 59995b3 - Browse repository at this point
Copy the full SHA 59995b3View commit details
Commits on Dec 16, 2023
-
fix: Prevent duplicative offline status indicators
Hoist the `OfflineStatus` indicator from the block list to the editor. The block list is leveraged for inner blocks, which means it rendered nested `OfflineStatus` indicators for blocks with inner blocks. Additionally, the `editor` package feels like an appropriate location for the offline detection component.
Configuration menu - View commit details
-
Copy full SHA for 30bf2a0 - Browse repository at this point
Copy the full SHA 30bf2a0View commit details
Commits on Dec 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for cb7e168 - Browse repository at this point
Copy the full SHA cb7e168View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ce863f - Browse repository at this point
Copy the full SHA 1ce863fView commit details -
refactor: Fix HoC name reference
This was renamed in a commit onto which this branch was rebased.
Configuration menu - View commit details
-
Copy full SHA for c223aa8 - Browse repository at this point
Copy the full SHA c223aa8View commit details -
refactor: Enable Fast Refresh for Image component
Place non-React component exports in a separate module to enable Fast Refresh of the React component.
Configuration menu - View commit details
-
Copy full SHA for 22e5851 - Browse repository at this point
Copy the full SHA 22e5851View commit details -
feat: Update the image offline message
Match the latest design comps.
Configuration menu - View commit details
-
Copy full SHA for cdae407 - Browse repository at this point
Copy the full SHA cdae407View commit details -
refactor: Avoid unnecessary inconsistency in switch case logic
Replace early return with logic mirroring the rest of the switch case statements. While I suppose it could be considered subjective, it is odd and confusing that one of the three cases was structured differently.
Configuration menu - View commit details
-
Copy full SHA for dd4e5db - Browse repository at this point
Copy the full SHA dd4e5dbView commit details -
refactor: Enable Fast Refresh for Image component
Place non-React component exports in a separate module to enable Fast Refresh of the React component.
Configuration menu - View commit details
-
Copy full SHA for 070979a - Browse repository at this point
Copy the full SHA 070979aView commit details -
feat: Revert logic intended to display progress bar when offline
I believe this logic erroneously prevented the spinner progress bar from displaying when an image is successfully uploading. I.e., the logic read "if show spinner and online, apply 'progress bar hidden' styles." I imagine this confusion is a result of the previous logic using the `||` pattern to conditionally apply the hidden styles, which is confusing in itself. This logic should likely be implemented by the way the host app communicates the upload state. Implementing this in the JavaScript logic is confusing or misleading, in my opinion. It adds a new, somewhat surprising interpretation of the existing states provided by the host app.
Configuration menu - View commit details
-
Copy full SHA for 533a348 - Browse repository at this point
Copy the full SHA 533a348View commit details -
refactor: Remove sizing from offline SVG
This allows sizing the icon for different contexts.
Configuration menu - View commit details
-
Copy full SHA for 4e92330 - Browse repository at this point
Copy the full SHA 4e92330View commit details -
feat: Update Image block media upload visuals
Update iconography and messaging when offline or or there is a upload error.
Configuration menu - View commit details
-
Copy full SHA for ec9f1a0 - Browse repository at this point
Copy the full SHA ec9f1a0View commit details
Commits on Dec 22, 2023
-
feat: Add paused media upload state
Relying upon the network connection status alone results in the error message erroneously changing whenever a network connection is re-established. The error message, in fact, is a state communicated from the host app's attempt to upload media. Therefore, this creates a new pause state to represent uploads paused while offline.
Configuration menu - View commit details
-
Copy full SHA for 4938a1e - Browse repository at this point
Copy the full SHA 4938a1eView commit details
Commits on Dec 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a5d533d - Browse repository at this point
Copy the full SHA a5d533dView commit details
Commits on Jan 2, 2024
-
feat: Scope the paused upload state to the Image block
The planned scope of the project was to improve the upload experience of the Image block, as it is the most frequently used media block type. Support for additional block types could be added at a later time.
Configuration menu - View commit details
-
Copy full SHA for a66e3ae - Browse repository at this point
Copy the full SHA a66e3aeView commit details -
feat: Enable paused media uploads for Media and Text block types
Because the Media and Text block type relies upon a nested Image block, it makes sense to enable the paused media uploads for a consistent UX.
Configuration menu - View commit details
-
Copy full SHA for 4927d9f - Browse repository at this point
Copy the full SHA 4927d9fView commit details -
perf: Avoid unnecessary state updates and callback invocations
If the upload state and progress is identical, there should be no reason to invoke callbacks, update component state, or re-render.
Configuration menu - View commit details
-
Copy full SHA for 210b43f - Browse repository at this point
Copy the full SHA 210b43fView commit details
Commits on Jan 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 21aa5a5 - Browse repository at this point
Copy the full SHA 21aa5a5View commit details -
feat: Add Android paused media upload bridge methods
Enables the Android host app to mirror the functionality of iOS.
Configuration menu - View commit details
-
Copy full SHA for 9db9142 - Browse repository at this point
Copy the full SHA 9db9142View commit details
Commits on Jan 4, 2024
-
Merge branch 'trunk' of github.com:WordPress/gutenberg into rnmobile/…
…media-upload-progress-connection-subscription
Configuration menu - View commit details
-
Copy full SHA for 8c441f8 - Browse repository at this point
Copy the full SHA 8c441f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 96b7c0c - Browse repository at this point
Copy the full SHA 96b7c0cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b6600f - Browse repository at this point
Copy the full SHA 6b6600fView commit details