Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update Image block failed upload visuals #56937

Merged

Commits on Dec 14, 2023

  1. refactor: Rename useIsConnected to useNetworkConnectivity

    Attempt to better communicate the Hook intent.
    dcalhoun committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    62191f5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1af5f0e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    25d141a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ddc08b8 View commit details
    Browse the repository at this point in the history
  5. fix: Optimistically presume network connectivity

    Prior to making the asynchronous request to the host app across the
    bridge, it is a better UX to presume network connectivity is present
    rather than displaying network connectivity messages briefly.
    dcalhoun committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    f7bccf5 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    59995b3 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2023

  1. fix: Prevent duplicative offline status indicators

    Hoist the `OfflineStatus` indicator from the block list to the editor.
    The block list is leveraged for inner blocks, which means it rendered
    nested `OfflineStatus` indicators for blocks with inner blocks.
    
    Additionally, the `editor` package feels like an appropriate location
    for the offline detection component.
    dcalhoun committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    30bf2a0 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2023

  1. Configuration menu
    Copy the full SHA
    cb7e168 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1ce863f View commit details
    Browse the repository at this point in the history
  3. refactor: Fix HoC name reference

    This was renamed in a commit onto which this branch was rebased.
    dcalhoun committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    c223aa8 View commit details
    Browse the repository at this point in the history
  4. refactor: Enable Fast Refresh for Image component

    Place non-React component exports in a separate module to enable Fast
    Refresh of the React component.
    dcalhoun committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    22e5851 View commit details
    Browse the repository at this point in the history
  5. feat: Update the image offline message

    Match the latest design comps.
    dcalhoun committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    cdae407 View commit details
    Browse the repository at this point in the history
  6. refactor: Avoid unnecessary inconsistency in switch case logic

    Replace early return with logic mirroring the rest of the switch case
    statements. While I suppose it could be considered subjective, it is
    odd and confusing that one of the three cases was structured
    differently.
    dcalhoun committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    dd4e5db View commit details
    Browse the repository at this point in the history
  7. refactor: Enable Fast Refresh for Image component

    Place non-React component exports in a separate module to enable Fast
    Refresh of the React component.
    dcalhoun committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    070979a View commit details
    Browse the repository at this point in the history
  8. feat: Revert logic intended to display progress bar when offline

    I believe this logic erroneously prevented the spinner progress bar from
    displaying when an image is successfully uploading. I.e., the logic read
    "if show spinner and online, apply 'progress bar hidden' styles." I
    imagine this confusion is a result of the previous logic using the `||`
    pattern to conditionally apply the hidden styles, which is confusing
    in itself.
    
    This logic should likely be implemented by the way the host app
    communicates the upload state. Implementing this in the JavaScript logic
    is confusing or misleading, in my opinion. It adds a new, somewhat
    surprising interpretation of the existing states provided by the host
    app.
    dcalhoun committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    533a348 View commit details
    Browse the repository at this point in the history
  9. refactor: Remove sizing from offline SVG

    This allows sizing the icon for different contexts.
    dcalhoun committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    4e92330 View commit details
    Browse the repository at this point in the history
  10. feat: Update Image block media upload visuals

    Update iconography and messaging when offline or or there is a upload
    error.
    dcalhoun committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    ec9f1a0 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2023

  1. feat: Add paused media upload state

    Relying upon the network connection status alone results in the error
    message erroneously changing whenever a network connection is
    re-established. The error message, in fact, is a state communicated from
    the host app's attempt to upload media. Therefore, this creates a new
    pause state to represent uploads paused while offline.
    dcalhoun committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    4938a1e View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2023

  1. Configuration menu
    Copy the full SHA
    a5d533d View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2024

  1. feat: Scope the paused upload state to the Image block

    The planned scope of the project was to improve the upload experience of
    the Image block, as it is the most frequently used media block type.
    Support for additional block types could be added at a later time.
    dcalhoun committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    a66e3ae View commit details
    Browse the repository at this point in the history
  2. feat: Enable paused media uploads for Media and Text block types

    Because the Media and Text block type relies upon a nested Image block,
    it makes sense to enable the paused media uploads for a consistent UX.
    dcalhoun committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    4927d9f View commit details
    Browse the repository at this point in the history
  3. perf: Avoid unnecessary state updates and callback invocations

    If the upload state and progress is identical, there should be no reason
    to invoke callbacks, update component state, or re-render.
    dcalhoun committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    210b43f View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2024

  1. Configuration menu
    Copy the full SHA
    21aa5a5 View commit details
    Browse the repository at this point in the history
  2. feat: Add Android paused media upload bridge methods

    Enables the Android host app to mirror the functionality of iOS.
    dcalhoun committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    9db9142 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2024

  1. Merge branch 'trunk' of github.com:WordPress/gutenberg into rnmobile/…

    …media-upload-progress-connection-subscription
    dcalhoun committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    8c441f8 View commit details
    Browse the repository at this point in the history
  2. docs: Add change log entry

    dcalhoun committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    96b7c0c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6b6600f View commit details
    Browse the repository at this point in the history