Block editor: hooks: avoid BlockEdit filter for content locking UI #56957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -446 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in e6fa033. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7172720743
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Similar to all the other hooks (#56862): we should avoid the hook here and avoid mounting this component for every single block on the page. It should only be mounted when controls should be displayed.
Why?
This will improve typing performance, but especially load (first block) performance.
First run: -5% load time (first block).
Second run: -6%.
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast