Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patterns: edit source pattern in focus mode in post and site editors #57036

Merged
merged 32 commits into from
Jan 3, 2024
Merged

Patterns: edit source pattern in focus mode in post and site editors #57036

merged 32 commits into from
Jan 3, 2024

Commits on Jan 3, 2024

  1. Move synced patterns global editing to focus mode in editor

    @glendaviesnz @talldan
    glendaviesnz authored and talldan committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    eb0e0af View commit details
    Browse the repository at this point in the history

  2. Add back padding to focus mode and notice to indicate global nature o… 

    …f changes
    @glendaviesnz @talldan
    glendaviesnz authored and talldan committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    46f0d79 View commit details
    Browse the repository at this point in the history

  3. Update experiment wording

    @glendaviesnz @talldan
    glendaviesnz authored and talldan committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    026616b View commit details
    Browse the repository at this point in the history

  4. Move the edit mode function to the editor package

    @glendaviesnz @talldan
    glendaviesnz authored and talldan committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    a5cfffc View commit details
    Browse the repository at this point in the history

  5. Change label on edit button

    @glendaviesnz @talldan
    glendaviesnz authored and talldan committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    8ec78b4 View commit details
    Browse the repository at this point in the history

  6. Remove pattern-only mode

    @glendaviesnz @talldan
    glendaviesnz authored and talldan committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    4764b56 View commit details
    Browse the repository at this point in the history

  7. Revert more pattern-only mode code

    @glendaviesnz @talldan
    glendaviesnz authored and talldan committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    76904b9 View commit details
    Browse the repository at this point in the history

  8. Another revert

    @glendaviesnz @talldan
    glendaviesnz authored and talldan committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    4bb23e7 View commit details
    Browse the repository at this point in the history

  9. Add basic routing to post editor

    @glendaviesnz @talldan
    glendaviesnz authored and talldan committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    501e5d5 View commit details
    Browse the repository at this point in the history

  10. Add document bar and padding

    @glendaviesnz @talldan
    glendaviesnz authored and talldan committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    d57e06b View commit details
    Browse the repository at this point in the history

  11. Fix initialisation of post id and post type

    @glendaviesnz @talldan
    glendaviesnz authored and talldan committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    de518fa View commit details
    Browse the repository at this point in the history

  12. Only show header bar and padding if edit mode is set to focused

    @glendaviesnz @talldan
    glendaviesnz authored and talldan committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    5a2a0e7 View commit details
    Browse the repository at this point in the history

  13. refine check for edit mode

    @glendaviesnz @talldan
    glendaviesnz authored and talldan committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    e55a163 View commit details
    Browse the repository at this point in the history

  14. Remove routing

    @glendaviesnz @talldan
    glendaviesnz authored and talldan committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    4fb6273 View commit details
    Browse the repository at this point in the history

  15. Switch to a simple postHistory array for switching back from pattern … 

    …editing
    @glendaviesnz @talldan
    glendaviesnz authored and talldan committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    5fe18da View commit details
    Browse the repository at this point in the history

  16. move postHistory to a ref

    @glendaviesnz @talldan
    glendaviesnz authored and talldan committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    88e76a2 View commit details
    Browse the repository at this point in the history

  17. Move history settings into hook

    @glendaviesnz @talldan
    glendaviesnz authored and talldan committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    afb742b View commit details
    Browse the repository at this point in the history

  18. refine history stack slightly

    @glendaviesnz @talldan
    glendaviesnz authored and talldan committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    caa3349 View commit details
    Browse the repository at this point in the history

  19. Refactor usePostHistory to keep all history in a single array. Use … 

    …useReducer.
    @talldan
    talldan committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    8fd30e6 View commit details
    Browse the repository at this point in the history

  20. fix edit post specific classname

    @glendaviesnz @talldan
    glendaviesnz authored and talldan committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    e882647 View commit details
    Browse the repository at this point in the history

  21. Fix iframe classes

    @glendaviesnz @talldan
    glendaviesnz authored and talldan committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    64a462e View commit details
    Browse the repository at this point in the history

  22. Editing in focus mode - pass onSelectPost as editor setting

    @glendaviesnz @talldan
    glendaviesnz authored and talldan committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    ab7f344 View commit details
    Browse the repository at this point in the history

  23. Minor tidy ups

    @glendaviesnz @talldan
    glendaviesnz authored and talldan committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    917e6a1 View commit details
    Browse the repository at this point in the history

  24. Move from onSelectPost to getPostLinkProps and add new hook in site e… 

    …ditor instead of trying to reuse useLink
    @glendaviesnz @talldan
    glendaviesnz authored and talldan committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    266c6c6 View commit details
    Browse the repository at this point in the history

  25. Fixes from code review

    @glendaviesnz @talldan
    glendaviesnz authored and talldan committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    4a6c7c3 View commit details
    Browse the repository at this point in the history

  26. Another fix from review

    @glendaviesnz @talldan
    glendaviesnz authored and talldan committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    925efaf View commit details
    Browse the repository at this point in the history

  27. Add optional state param to call to history.push

    @glendaviesnz @talldan
    glendaviesnz authored and talldan committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    c37010d View commit details
    Browse the repository at this point in the history

  28. Remove code duplication in usePostLinkProps hook

    @glendaviesnz @talldan
    glendaviesnz authored and talldan committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    de462a0 View commit details
    Browse the repository at this point in the history

  29. make sure block editing mode set to default when going to edit original

    @glendaviesnz @talldan
    glendaviesnz authored and talldan committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    638e0d2 View commit details
    Browse the repository at this point in the history

  30. Tidy up edit mode assignment

    @glendaviesnz @talldan
    glendaviesnz authored and talldan committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    f0c08de View commit details
    Browse the repository at this point in the history

  31. Don't adjust the url if moving to focused mode of entity from post

    @glendaviesnz @talldan
    glendaviesnz authored and talldan committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    9465f9f View commit details
    Browse the repository at this point in the history

  32. Change how updating of url is bypassed when switching to focused mode… 

    … editing
    @glendaviesnz @talldan
    glendaviesnz authored and talldan committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    6bc3abb View commit details
    Browse the repository at this point in the history