Components: replace TabPanel with Tabs in the Style Book
#57287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 tasks
|
Size Change: +34 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in ac33698. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7280931751
|
chad1008
force-pushed
the
tabs-style-book
branch
from
ac33698
to
20d14b3
Compare
chad1008
added
[Type] Enhancement
ciampo
reviewed
Jan 3, 2024
There was a problem hiding this comment.
Code changes LGTM 🚀
One slightly different behavior that I noticed: on trunk, pressing Tab while focusing a tab moves focus to the tabpanel, while on this PR focus moves directly to the first focusable element in the tabpanel.
I personally prefer the behaviour in this PR, but we should make sure that there wasn't any particular reason for the previous behavior to justify keeping it around?
ciampo
approved these changes
Jan 3, 2024
This observation threw me a bit, because I'd specifically tried to emulate the existing behavior so I played around with it a bit and I think I understand what's happening (though not entirely why, but that's a question for another day/PR) If you launch the site editor, and immediately open the Global Styles sidebar, followed by the Style Book, Tab will move you to the first/current tab, and then to the first focusable item within the displayed However, if you mess around in the editor and focus a block before opening Global Styles & Style Book, the focus behavior changes. Tab still starts by landing on the currently selected tab, but then cycles through various other elements instead of moving directly into the While this feels off, and I'm not sure what causes it, the behavior seems consistent between |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Replaces the legacy TabPanel component with the new Tabs component.
Why?
Part of the work outlined in #52997
How?
TabPanelis replaced byTabsand its sub-components.Testing Instructions
Testing Instructions for Keyboard