Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip: improve tests #57345

Merged
merged 25 commits into from
Jan 4, 2024
Merged

Tooltip: improve tests #57345

merged 25 commits into from
Jan 4, 2024

Commits on Jan 3, 2024

  1. Remove unnecessary RegExp

    @ciampo
    ciampo committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    e826e66 View commit details
    Browse the repository at this point in the history

  2. Use @ariakit/test instead of testing library

    @ciampo
    ciampo committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    6ca3f5d View commit details
    Browse the repository at this point in the history

  3. Use sleep utility instead of custom promise

    @ciampo
    ciampo committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    6b5334f View commit details
    Browse the repository at this point in the history

  4. Remove unnecessary import

    @ciampo
    ciampo committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    c97a986 View commit details
    Browse the repository at this point in the history

  5. Add utility functions

    @ciampo
    ciampo committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    8292091 View commit details
    Browse the repository at this point in the history

  6. Make multiple children test actually test what it's supposed to test

    @ciampo
    ciampo committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    32b5703 View commit details
    Browse the repository at this point in the history

  7. Test for tooltip to hide when another element gets focus

    @ciampo
    ciampo committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    8cd4033 View commit details
    Browse the repository at this point in the history

  8. Test for tooltip to hide when hovering outside the anchor

    @ciampo
    ciampo committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    3894dca View commit details
    Browse the repository at this point in the history

  9. Improve tooltip hiding on click test

    @ciampo
    ciampo committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    a6ca61f View commit details
    Browse the repository at this point in the history

  10. More utils refactor

    @ciampo
    ciampo committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    7674cb0 View commit details
    Browse the repository at this point in the history

  11. Improve test with disabled anchor

    @ciampo
    ciampo committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    0c47cab View commit details
    Browse the repository at this point in the history

  12. Wait for tooltip to be hidden in the hideOnClick={false} test

    @ciampo
    ciampo committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    18a228c View commit details
    Browse the repository at this point in the history

  13. Refactor custom delay test

    @ciampo
    ciampo committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    5e590e3 View commit details
    Browse the repository at this point in the history

  14. Refactor "mouse leave early" test (skip as it's still not passing)

    @ciampo
    ciampo committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    4fe91bc View commit details
    Browse the repository at this point in the history

  15. Improve shortcut-related tests

    @ciampo
    ciampo committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    be278f8 View commit details
    Browse the repository at this point in the history

  16. Improve the Modal Escape test

    @ciampo
    ciampo committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    090e22b View commit details
    Browse the repository at this point in the history

  17. Refactor description text test

    @ciampo
    ciampo committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    b5aaf5a View commit details
    Browse the repository at this point in the history

  18. Add second-level describes

    @ciampo
    ciampo committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    cf1ea1a View commit details
    Browse the repository at this point in the history

  19. Improve TS expecte error message

    @ciampo
    ciampo committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    2d4692a View commit details
    Browse the repository at this point in the history

  20. Add missing async/await in test utils

    @ciampo
    ciampo committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    536ddeb View commit details
    Browse the repository at this point in the history

  21. Await for tooltip to appear in shortcut tests

    @ciampo
    ciampo committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    636678f View commit details
    Browse the repository at this point in the history

  22. Apply delay prop only when showing the tooltip

    @ciampo
    ciampo committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    0e8c5e6 View commit details
    Browse the repository at this point in the history

  23. Add skip timeout waiting time after each test

    @ciampo
    ciampo committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    57b5335 View commit details
    Browse the repository at this point in the history

  24. CHANGELOG

    @ciampo
    ciampo committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    21d2c0e View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2024

  1. Apply review feedback

    @ciampo
    ciampo committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    89372ed View commit details
    Browse the repository at this point in the history