Gallery Block: Remove unused attributes property in shortcode transformation #57356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Code Quality
|
Size Change: -180 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
t-hamano
commented
Dec 23, 2023
| images: { | ||
| type: 'array', | ||
| shortcode: ( { named: { ids } } ) => { | ||
| if ( ! isGalleryV2Enabled() ) { |
There was a problem hiding this comment.
There is no check in transforms whether the Gallery block is v2 or not. However, since the Gallery block v2 is enabled in all WordPress versions supported by the current Gutenberg plugin, I don't think it is necessary to add this check to transforms.
t-hamano
requested review from
Mamaduka,
talldan,
glendaviesnz and
kevin940726
|
@t-hamano, can you share an example shortcode for testing this changes? Thank you! |
|
@Mamaduka Sorry, I didn't include the actual shortcode. Added to Testing Instructions. |
|
Flaky tests detected in f7a66eb. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7306510677
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #57345
Noticed this while investigating #9701
What?
This PR removes unused
attributesproperty during the process of transforming the gallery shortcode to the Gallery block.Why?
When I tried to update the gallery shortcode transformation process, I noticed that
attributes.X.shortcodewas not working. This is because transforms take precedence over attributes, and you can see that they are implemented that way by looking at the code.How?
I just deleted it.
Testing Instructions
[gallery columns="2" link="post" size="large" ids="46,45,44,43,42"]