Fix Snapshots: Update color-palette and toggle-group snapshots with data-command #57380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbravobernal
added
the
[Type] Bug
|
Tests are failing in the CI, just the other way around. Closing the PR, it seems that my local system is messed. |
|
Flaky tests detected in b54ad34. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7330571155
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
npm run test:unitis asking to update the snapshotsI'm not 100% sure if this data attribute is needed on these elements, so I'm asking for the review to components experts :-)
Testing Instructions
Run
npm run test:unitin trunk to check the errors.Run
npm run test:unitin the branch to check that are fixed.Testing Instructions for Keyboard
Screenshots or screencast