Ignore HTML Elements in ReduxDevTools #57497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Bug
|
Size Change: +12 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
getdave
approved these changes
Feb 24, 2024
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
getdave
force-pushed
the
fix/dom-element-in-state
branch
from
7c60b0c
to
d3c588b
Compare
|
Rebasing to get ✅ |
|
I merged this as the scope is limited to only when redux dev tools extension is active and open so it's relatively limited. The devex problems were pretty bad so I wanted to bring this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you use ReduxDevTools, you may notice a JS error in the site editor because we're storing a non serializable element in the state. This PR ignores HTML element stored in redux state from being shown in the dev tools. There might be better ways to represent these in the dev tools though.