Font Library: singularize install font families endpoint #57569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mily instead of many in the same request
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/experimental/fonts/font-library/class-wp-rest-font-families-controller.php ❔ phpunit/tests/fonts/font-library/wpRestFontFamiliesController/installFonts.php |
|
Size Change: +1.5 kB (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
mikachan
added
[Type] Enhancement
25 tasks
jffng
approved these changes
Jan 6, 2024
There was a problem hiding this comment.
I tested and verified the following via the UI:
✅ Font families can be installed (singularly)
✅ Cannot upload or install variants of more than one font family
✅ Tests pass locally
I left a few minor comments all related to the same issue.
While testing I discovered that a notice is being thrown related to the REST API anytime the Font Library UI is loaded:
PHP Notice: Undefined index: paged in /site/path/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php on line 394
PHP Stack trace:
...
PHP 13. WP_REST_Font_Families_Controller->get_items() /site/path/wp-includes/rest-api/class-wp-rest-server.php:1193
It probably started when we updated the REST Controller to extend the Posts Controller, so we can address it separate from this PR.
Approving so long as the minor comments are addressed, LGTM.
lib/experimental/fonts/font-library/class-wp-rest-font-families-controller.php
Outdated
Show resolved
Hide resolved
lib/experimental/fonts/font-library/class-wp-rest-font-families-controller.php
Outdated
Show resolved
Hide resolved
lib/experimental/fonts/font-library/class-wp-rest-font-families-controller.php
Outdated
Show resolved
Hide resolved
Yep that notice is related to the implementation of the Post Rest Controller, we could work on it on a separate PR. I created an issue with your report. Thanks for testing and reviewing @jffng ! |
matiasbenedetto
deleted the
refactor/singularize-install-font-families-endpoint
branch
bph
added
the
Needs Dev Note
youknowriad
added
Backported to WP Core
32 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Why?
To make the
POST /font-families/endpoint accept only one font family per request instead of many.This is part of the effort around refactoring the Font Library API.
How?
Removing the capability to install several font families using only one request.
Testing Instructions