[Mobile] - Fix missing custom gradient indicator in the color palette #57605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geriux
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.69 MB ℹ️ View Unchanged
|
|
Flaky tests detected in f634ef2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7424245693
|
geriux
removed
the
Mobile App - Automation
added 3 commits
January 8, 2024 11:09
fluiddot
approved these changes
Jan 8, 2024
packages/components/src/mobile/color-settings/palette.screen.native.js
Outdated
Show resolved
Hide resolved
added 4 commits
January 10, 2024 15:00
# Conflicts: # packages/react-native-editor/CHANGELOG.md
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42017
What?
This PR fixes a regression most likely introduced in #38417 where we added support for multiple color palettes where the custom color indicator is not shown for custom gradient colors.
Why?
To fix a UI regression and possibly avoid confusion for users when they customize their gradient colors.
How?
The custom indicator wasn't being shown due to not having all of the gradient colors available for the current color segment being rendered.
We also limit the custom indicator to only be visible in the first available color palette row, since users can have up to three:
Default,Theme, andCustomcolors.Testing Instructions
Note
These changes need to be tested using the main host apps and a theme that has custom gradients e.g: Twenty Twenty-Four
Testing Instructions for Keyboard
N/A
Screenshots or screencast
GradientIndicatorFix.mov