Add token UI concept to Link UI #57755
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Enhancement
|
Size Change: +15 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
getdave
force-pushed
the
try/link-control-link-tokens
branch
from
24930d4
to
9f0acdc
Compare
|
What is this token thing we mention? |
I tried here #50892 (comment) |
|
So the "token" is the preview box now shown in edit mode? I tested this and it works as described, 👏🏻 and the code looks good. But I won't ✅ since I am not sure @richtabor is this something your current designs include? Does the downside of cluttering vertical space lose to this token idea? Does the token really convey the difference between the types of links? In my testing there is nothing that stood out to me to make me understand one is internal and one is external and one is self updating and one is not ... so not sure what the preview helps with 😄 |
|
Thanks for your review Andrei 👍 I discussed this a bit with @richtabor and neither of us was totally convinced of having the preview in the edit mode either. Upside is that it's quite a nice transition into edit mode. We are also starting to convey when you are editing a Post vs Static - although it needs refining. Downside is that it occupies even more vertical space which isn't great. I think we should keep this in mind because for work such as #46891 IMHO we do need some way to convey "you have linked to a Post which will automatically update" vs "you have linked to a static URL". Open to suggestions on how the UI / UX could be improved to better convey the concept, or alternatively suggestions for how we can dynamically update a link that is also editable by the user. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds a "token" preview of the currently selected link when the Link UI is in "edit" state.
Part of #50892
Why?
This is a first step towards UX work on the Link UI to make clear when you have link to:
The key difference is that a URL is static and doesn't change underneath you where as an entity is dynamic and it's attributes may change.
For example, let's say you link to "My Sample Post" and the permalink for that is
/my-sample-post. Next week you rename the Post to "My New Name Post" and also update the slug - the permalink is now/my-new-name-post.Unfortunately the link you made last week doesn't dynamically update and you have to go back and manually update it.
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Screen.Capture.on.2024-01-11.at.09-57-14.mp4