Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve dot issue of block toolbar #57791

Conversation

NidhiDhandhukiya74
Copy link

What?

Resolve the mentioned issue :- #57713

How?

Whenever we have choosen Show button text labels this from the Preference then in toolbar small dot appear at the end of toolbar.

Testing Instructions

  • Disable "Fixed toolbar" from the Options menu.
  • From Preference in Accessibility make toggle true Show button text labels
  • Insert a Group block.
  • Add Paragraph block with in it.
  • There should be a dot at the right end of the block toolbar.

Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @NidhiDhandhukiya74! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jan 12, 2024
@t-hamano t-hamano added [Package] Block editor /packages/block-editor CSS Styling Related to editor and front end styles, CSS-specific issues. labels Jan 20, 2024
@t-hamano
Copy link
Contributor

Hi @NidhiDhandhukiya,

This problem could not be reproduced with the latest Gutenberg. After investigating the cause, it appears that it was unintentionally fixed in #57728. If you compare the before and after screenshots in the PR, you can see that the dots have disappeared.

Therefore, I would like to close this PR, but thank you for your efforts 👍

@t-hamano t-hamano closed this Jan 20, 2024
@t-hamano t-hamano added the [Type] Bug An existing feature does not function as intended label Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Package] Block editor /packages/block-editor [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants