-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Font Library: disable font library UI using a PHP filter #57818
Conversation
Co-authored-by: Jeff Ong <5375500+jffng@users.noreply.github.com>
Size Change: +36 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
Flaky tests detected in b4a2699. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7506595513
|
Co-authored-by: Jeff Ong <5375500+jffng@users.noreply.github.com>
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/load.php |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer this PR because it is fewer code changes. We can always export the setting later / add it to the Font Library context to be reused when the need arises.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this LGTM too!
Fix comment block accidentally broken here: #57818
Fix comment block accidentally broken here: #57818
What?
Adds the ability to disable the Font Library UI using a PHP filter.
This PR just simplifies the work done by @jffng in this PR: #57773
Why?
To make extenders able to disable the font library UI
How?
Reading the editor settings from the data store.
Testing Instructions
May fi x:#55275