Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomSelect: Adapt component for legacy props #57902

Merged
merged 52 commits into from
Feb 10, 2024
Merged

CustomSelect: Adapt component for legacy props #57902

merged 52 commits into from
Feb 10, 2024

Commits on Feb 6, 2024

  1. Move components to own files

    @brookewp
    brookewp committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    64c2947 View commit details
    Browse the repository at this point in the history

  2. Add legacy adapter

    @brookewp
    brookewp committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    4250494 View commit details
    Browse the repository at this point in the history

  3. Add legacy tests

    @brookewp
    brookewp committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    d3da53a View commit details
    Browse the repository at this point in the history

  4. Update naming and remove unnecessary tests

    @brookewp
    brookewp committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    c3d6a80 View commit details
    Browse the repository at this point in the history

  5. Add legacy props to adapter

    @brookewp
    brookewp committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    4c9f32f View commit details
    Browse the repository at this point in the history

  6. Create new component to forward store

    @brookewp
    brookewp committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    7d9bc28 View commit details
    Browse the repository at this point in the history

  7. Create legacy component

    @brookewp
    brookewp committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    d2b30d6 View commit details
    Browse the repository at this point in the history

  8. Remove useDeprecatedProps hook and update adapter

    @brookewp
    brookewp committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    905b9fe View commit details
    Browse the repository at this point in the history

  9. Separate stories

    @brookewp
    brookewp committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    940cdaf View commit details
    Browse the repository at this point in the history

  10. Update stories and types

    @brookewp
    brookewp committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    82b33d1 View commit details
    Browse the repository at this point in the history

  11. Convert function into variable instead

    @brookewp
    brookewp committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    f1b5320 View commit details
    Browse the repository at this point in the history

  12. Update legacy changeObject to match existing properties

    @brookewp
    brookewp committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    c3f4a23 View commit details
    Browse the repository at this point in the history

  13. Add tests for onChange function

    @brookewp
    brookewp committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    a98e38c View commit details
    Browse the repository at this point in the history

  14. add rest of legacy props

    @brookewp
    brookewp committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    09e9c47 View commit details
    Browse the repository at this point in the history

  15. Update sizing

    @brookewp
    brookewp committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    80158a6 View commit details
    Browse the repository at this point in the history

  16. Memoize selected render value

    @brookewp
    brookewp committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    2ccdc91 View commit details
    Browse the repository at this point in the history

  17. Remove deprecated prop to fix test failures

    @brookewp
    brookewp committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    46283b5 View commit details
    Browse the repository at this point in the history

  18. Add unmountOnHide and require defaultValue as a result 

    See: ariakit/ariakit#3374 (comment)
    @brookewp
    brookewp committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    2526b8e View commit details
    Browse the repository at this point in the history

  19. Update styling for experimental hint

    @brookewp
    brookewp committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    a8b4e8a View commit details
    Browse the repository at this point in the history

  20. Connect CustomSelectButton to context system for legacy sizing

    @brookewp
    brookewp committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    bc1cbe7 View commit details
    Browse the repository at this point in the history

  21. Update sizing logic and types

    @brookewp
    brookewp committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    002bd2e View commit details
    Browse the repository at this point in the history

  22. Fix styling to match legacy including hints

    @brookewp
    brookewp committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    85993fd View commit details
    Browse the repository at this point in the history

  23. Clean up props

    @brookewp
    brookewp committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    1524180 View commit details
    Browse the repository at this point in the history

  24. Omit ‘onChange’ from WordPressComponentProps to prevent conflict

    @brookewp
    brookewp committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    eb4e946 View commit details
    Browse the repository at this point in the history

  25. Update checkmark icon

    @brookewp
    brookewp committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    fdabba7 View commit details
    Browse the repository at this point in the history

  26. Update select arrow

    @brookewp
    brookewp committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    2bc69ef View commit details
    Browse the repository at this point in the history

  27. Update types

    @brookewp
    brookewp committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    63c3dd4 View commit details
    Browse the repository at this point in the history

  28. Add static typing test

    @brookewp
    brookewp committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    1280774 View commit details
    Browse the repository at this point in the history

  29. Update story for better manual testing

    @brookewp
    brookewp committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    d25764b View commit details
    Browse the repository at this point in the history

  30. Control mount state for legacy keyboard behaviour

    @brookewp
    brookewp committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    18e15e9 View commit details
    Browse the repository at this point in the history

  31. Remove export that is no longer needed

    @brookewp
    brookewp committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    e0caf2d View commit details
    Browse the repository at this point in the history

  32. Update legacy onChange type

    @brookewp
    brookewp committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    cafbdf8 View commit details
    Browse the repository at this point in the history

  33. Update tests

    @brookewp
    brookewp committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    7b86a97 View commit details
    Browse the repository at this point in the history

  34. Update naming

    @brookewp
    brookewp committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    bc7027e View commit details
    Browse the repository at this point in the history

  35. Try mounting on first render to avoid required defaultValue

    @brookewp
    brookewp committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    4f9f6f9 View commit details
    Browse the repository at this point in the history

  36. Add WordPressComponentProps to default export

    @brookewp
    brookewp committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    71b2c1a View commit details
    Browse the repository at this point in the history

  37. Update types

    @brookewp
    brookewp committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    be17780 View commit details
    Browse the repository at this point in the history

  38. Replace RTL/userEvent with ariakit/test

    @brookewp
    brookewp committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    287c354 View commit details
    Browse the repository at this point in the history

  39. Remove unmountOnHide and related logic for first iteration

    @brookewp
    brookewp committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    7eb2134 View commit details
    Browse the repository at this point in the history

  40. Update docs

    @brookewp
    brookewp committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    c794d06 View commit details
    Browse the repository at this point in the history

  41. Update naming

    @brookewp
    brookewp committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    5c58f78 View commit details
    Browse the repository at this point in the history

  42. Merge new tests and update to ariakit/test

    @brookewp
    brookewp committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    c73ce18 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. Fix typo in readme

    @mirka
    mirka committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    795df54 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Legacy: Clean up stories

    @mirka
    mirka committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    4171c67 View commit details
    Browse the repository at this point in the history

  2. Default: Clean up stories

    @mirka
    mirka committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    8d70b4f View commit details
    Browse the repository at this point in the history

  3. Add todo comment about BaseControl

    @mirka
    mirka committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    cb88b8b View commit details
    Browse the repository at this point in the history

  4. Fix styles

    @mirka
    mirka committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    d2dfe8b View commit details
    Browse the repository at this point in the history

  5. Rename styled components for consistency

    @mirka
    mirka committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    ddc8e6b View commit details
    Browse the repository at this point in the history

  6. Fix typo in readme

    @mirka
    mirka committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    faa6d7b View commit details
    Browse the repository at this point in the history

  7. Merge branch 'trunk' into add/legacy-adapter-customselectcontrol

    @mirka
    mirka committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    797e139 View commit details
    Browse the repository at this point in the history

  8. Rename for clarity

    @mirka
    mirka committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    f8446f8 View commit details
    Browse the repository at this point in the history

  9. Update changelog

    @mirka
    mirka committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    3a2be41 View commit details
    Browse the repository at this point in the history