Interactivity API: Create @wordpress/interactivity-router module
#57924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/compat/wordpress-6.5/interactivity-api/class-wp-interactivity-api.php |
|
Size Change: +204 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
47 tasks
DAreRodz
force-pushed
the
add/interactivity-api-wp-each
branch
from
6635608
to
00650c7
Compare
youknowriad
reviewed
Jan 24, 2024
| if ( request === '@wordpress/interactivity-router' ) { | ||
| // Assumes this is usually giong to be used as a dynamic import. | ||
| return `import ${ request }`; | ||
| } |
There was a problem hiding this comment.
This is the kind of change that I'd like us to improve as part of adding these new modules, we should be adding hacks like this when we create new packages/modules. Instead we should have everything taken care of automatically. How can we do that here?
There was a problem hiding this comment.
Ideally, all the WordPress packages should be available as modules. Once that's done, we can update this to do something similar to what's done for scripts and make any module that starts with @wordpress external.
This reverts commit e551609.
|
Flaky tests detected in 980ad9b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7644906646
|
This reverts commit 3e50a84.
…ule' into try/interactivity-api-router-module
luisherranz
approved these changes
Jan 24, 2024
|
I noticed this PR was merged after I raised the PHP Sync Tracking Issue for WP 6.5 and has changed PHP files that may need backporting to WP Core. Apologies if you have already mentioned this but could I ask for confirmation as to whether this PR will need a backport? |
|
Hi @getdave ! The only code that will need backport is the register of the router module. We are still finishing the definition of how we will register and enqueue script modules in Core. But we are fully aware of this change to be backported in Core for Beta 1. |
|
Yes, that registration will be part of the backport of this PR, so no need to do anything else here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Tracking issue: #56803
Created on top of #57859
Moves all the router-related code to its own module named
@wordpress/interactivity-router.The module exposes the
navigateandprefetchfunctions previously exported from@wordpress/interactivity, now as actions of thecore/routerstore.As a reference, these are the bundle size results before and after splitting the code.
About the table:
Content-Lengthheader in HTTP responses.Why?
To start splitting the Interactivity API into separate parts.
How?
router.jsfile is moved to its own folder and imports all the required dependencies from@wordpress/interactivityinstead of using relative imports.@wordpress/interactivity-routermodule is registered in Gutenberg.@wordpress/interactivity-routermodule is added as a dependency of the Query block'sview.jsmodule.Testing Instructions
interactivity/index.min.jsandinteractivity/query.min.jshave been requested, but notinteractivity/router.min.js.interactivity/router.min.jshas been requested.