DataViews: Fix rounded corners of cards in grid layout #58045
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Experimental
|
Size Change: +1 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
oandregal
approved these changes
Jan 22, 2024
|
@oandregal @jameskoster Thanks for the review!
In #58071, I noticed that the preview area was turned into a button. Therefore, this PR approach may conflict with #58071. Fortunately, #58071 also seems to solve the problem that this PR is trying to solve, so I would like to close this PR. |
|
Thanks for your work, @t-hamano. Even if this PR is not merged, it was still valuable to raise an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #57880
What?
This PR ensures that the rounded corners of cards are displayed correctly in the data view as a grid layout.
Before
After
Why?
This is because the background color of the content inside is protruding.
How?
Simply applied
overflow: hidden. Since the cards themselves are not focusable, the outline cutoff itself should not occur.Testing Instructions