Migrate remaining 'inserting blocks' e2e tests to Playwright #58108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
the
[Type] Automated Testing
Mamaduka
requested review from
kevin940726,
ntwb,
nerrad and
ajitbohra
as code owners
|
Size Change: -526 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
Mamaduka
commented
Jan 23, 2024
Mamaduka
commented
Jan 23, 2024
Mamaduka
requested review from
WunderBart
and removed request for
ntwb,
ajitbohra and
nerrad
|
Flaky tests detected in 5ba5380. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7636878508
|
Mamaduka
force-pushed
the
migrate/inserting-blocks-e2e-tests
branch
from
b950331
to
a3f98f0
Compare
Mamaduka
commented
Jan 23, 2024
| await admin.createNewPost(); | ||
| await editor.openDocumentSettingsSidebar(); |
There was a problem hiding this comment.
The test expects the document settings sidebar to be open, otherwise keyboard navigation fails.
Mamaduka
commented
Jan 23, 2024
| } ); | ||
|
|
||
| // Check for regression of https://github.com/WordPress/gutenberg/issues/27586. | ||
| test( 'can close the main inserter after inserting a single-use block, like the More block', async ( { |
There was a problem hiding this comment.
I have updated the test name here to reflect the intention better. Clicking on any black option in the inserter doesn't close it. The insertBlock help utility provided the original test behavior.
Mamaduka
force-pushed
the
migrate/inserting-blocks-e2e-tests
branch
from
5ba5380
to
6c78528
Compare
|
I have removed the skipped test. I think we are already covering those scenarios. |
Mamaduka
force-pushed
the
migrate/inserting-blocks-e2e-tests
branch
from
1eb1151
to
42bf6e6
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core SVNCore Committers: Use this line as a base for the props when committing in SVN: GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
kevin940726
approved these changes
Feb 6, 2024
Mamaduka
commented
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #38851.
PR migrates remaining active 'inserting blocks' e2e tests to Playwright.
Why?
See #38851
Note
One skipped test remains, but I wonder if it's worth migrating.
Besides the different types of inserter tests (already extensively covered), it also contains tests that should be part of the writing flow or shortcode block.
Testing Instructions