Components: Add eslint rule for theme var regressions #58130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Code Quality
mirka
commented
Jan 23, 2024
Comment on lines
+366
to
+376
| { | ||
| selector: 'Literal[value=/--wp-admin-theme-/]', | ||
| message: | ||
| '--wp-admin-theme-* variables do not support component theming. Use variables from the COLORS object in packages/components/src/utils/colors-values.js instead.', | ||
| }, | ||
| { | ||
| selector: | ||
| 'TemplateElement[value.cooked=/--wp-admin-theme-/]', | ||
| message: | ||
| '--wp-admin-theme-* variables do not support component theming. Use variables from the COLORS object in packages/components/src/utils/colors-values.js instead.', | ||
| }, |
There was a problem hiding this comment.
These two selectors will cover matches within string and template literals. (But not other types of nodes like comments.)
This was referenced Jan 23, 2024
|
Size Change: -63 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
Including some entries from my recent PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #44116
What?
Adds a Eslint rule for JS/TS files under
packages/componentsto prevent unknowing usage of--wp-admin-theme-*color variables.Why?
--wp-admin-theme-*variables are coupled with wp-admin and do not support our component theming system.This PR is the Eslint counterpart of the Stylelint rules proposed in #58098.
Testing Instructions
npm run lint:js. It should error on the offending files underpackages/components.