Prevent usage of gutenberg_url in block-library
#58242
Conversation
luisherranz
added
[Type] Bug
luisherranz
requested review from
artemiomorales,
michalczaplinski,
tellthemachines and
ajitbohra
as code owners
| '@wordpress/block-library/file-block', | ||
| gutenberg_url( '/build/interactivity/file.min.js' ), | ||
| '@wordpress/block-library/file', | ||
| defined( 'IS_GUTENBERG_PLUGIN' ) && IS_GUTENBERG_PLUGIN ? gutenberg_url( '/build/interactivity/file.min.js' ) : includes_url( 'blocks/file/view.min.js' ), |
There was a problem hiding this comment.
Just checking my understanding here. What's the long term vision for these wp_register_script_module calls? Are they going to be done automatically using block.json or if we need conditionals, maybe instead we should have generic calls like wp_hydrate_block( 'core/file' ) or something where the actual files are not hard-coded by guessed from block.json or something.
There was a problem hiding this comment.
As far as I remember @sirreal is working on a viewModule and viewScriptModule feature in block json. So should be done automatically.
There was a problem hiding this comment.
Yes. In the short term, we should replace them with viewScriptModule entries in the block.json. Then, at some point, I'd like to resume our work on behaviors where a single block can have a set of behaviors defined, and depending on the active ones, WordPress will enqueue the required JS and CSS files for those behaviors.
There was a problem hiding this comment.
why not viewModule? or do we use that for something else?
There was a problem hiding this comment.
In the beginning, we called it the Modules API but then everything was renamed to "script modules":
There was a problem hiding this comment.
Here's the viewScriptModule for Core: WordPress/wordpress-develop#5860
viewModule support was implemented in Gutenberg, but when "modules" became "script modules" in Core it seemed to make sense to align and use viewScriptModule, but that's still up for review.
* Prevent usage of gutenberg_url in block-library * Add includes_url * Update enqueue module identifiers
|
I just cherry-picked this PR to the release/17.6 branch to get it included in the next release: 385bf9f |
cbravobernal
removed
the
Backport to Gutenberg RC
* Prevent usage of gutenberg_url in block-library * Add includes_url * Update enqueue module identifiers
MaggieCabrera
added
[Feature] Blocks
What?
Prevent the usage of
gutenberg_urlin the interactive blocks of theblock-librarypackage.Why?
Because we mistakenly left it in the #57778 PR and
block-libraryshould never contain direct usage of Gutenberg functions because it's synced "as it is" in WordPress Core, where those functions don't exist.How?
By checking first if Gutenberg is activated, and if it's not, using
includes_urlinstead ofgutenberg_url.