Patterns: Change the pattern block overrides attribute name to content
#58285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
glendaviesnz
added
[Type] Enhancement
|
Size Change: -3 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
49 tasks
|
I like |
|
Doesn't this change break all the blocks that are already using the overrides currently on their websites? Because the old attributes aren't caught? |
Yeh, my vote would be to keep it as |
Yes, but up until this point this feature has been experimental, so subject to change, so shouldn't really have been used on production sites. But we will still take into account the potential impact on sites that were using it anyway before making a final decision on this. |
I don't think it impacts any decision, as a migration can be added for the attribute. That's something that should probably be included in this PR anyway, especially if this PR doesn't land in the plugin release tomorrow (since the release will remove the experiment flag for pattern overrides). |
glendaviesnz
force-pushed
the
refactor/pattern-overrides-attribute-name
branch
from
41d397f
to
5d45364
Compare
|
Flaky tests detected in 5d45364. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7718760913
|
|
closing for now as we are looking at changing this data structure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Changes the override attributes name from
overridestocontentWhy?
Feedback was received that this would be a more appropriate name.
How?
Renamed all the instances of the attribute in editor and frontend code.
Testing Instructions
contentBefore:
<!-- wp:block {"ref":233,"overrides":{"WZUl8h":{"content":[1,"my new content"]}} /-->After:
<!-- wp:block {"ref":233,"content":{"WZUl8h":{"content":[1,"my new content"]}} /-->