-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Heading block: Add integration test to cover changing heading level #58328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
[Type] Automated Testing
Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
[Block] Heading
Affects the Headings Block
labels
Jan 26, 2024
fluiddot
changed the title
[RNMobile] Heading block: Add integration tests to cover changing heading level
[RNMobile] Heading block: Add integration test to cover changing heading level
Jan 26, 2024
Size Change: 0 B Total Size: 1.7 MB ℹ️ View Unchanged
|
SiobhyB
reviewed
Jan 26, 2024
SiobhyB
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works perfectly for me, thank you for following up @fluiddot! 🙌
Co-authored-by: Siobhan Bamber <siobhan@automattic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Heading
Affects the Headings Block
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
[Type] Automated Testing
Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds integration test to cover changing the heading level in the Heading block.
Why?
We identified a crash in production (fixed in #58088) that could have been caught by this test case.
How?
Testing Instructions
Tests pass
Check that the test case could have caught the crash
toString
calls #58088.npm run test:native -- heading/test/index
.changes heading level
fails.Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A