Font Library: remove unused utilities and rename class

[creativecoder]

What?

• Removed unused font utility functions
• Rename WP_Font_Family_Utils to WP_Font_Utils, to indicate it's not only for font families
• Add comments to indicate utility functions are meant for internal use only

Why?

Additional Font Library code cleanup after the REST API refactor.

Testing Instructions

• Spot check the Font Library: all functionality should remain working as expected

[github-actions]

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files

❔ lib/experimental/fonts/font-library/class-wp-rest-font-faces-controller.php
❔ lib/experimental/fonts/font-library/class-wp-rest-font-families-controller.php
❔ lib/experimental/fonts/font-library/font-library.php
❔ lib/load.php
❔ phpunit/tests/fonts/font-library/wpFontLibrary/getMimeTypes.php
❔ phpunit/tests/fonts/font-library/wpRestFontFacesController.php
❔ lib/experimental/fonts/font-library/class-wp-font-utils.php
❔ phpunit/tests/fonts/font-library/wpFontUtils/formatFontFamily.php
❔ phpunit/tests/fonts/font-library/wpFontUtils/getFontFaceSlug.php

[github-actions]

Flaky tests detected in 85782fd.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7674631158
📝 Reported issues:

• [Flaky Test] directives inside islands should not be hydrated twice #58332 in /test/e2e/specs/interactivity/tovdom-islands.spec.ts

[mikachan]

I've given this a smoke test and everything is still working as expected.

I've also read through the code, and all the replacements and renaming look good and make sense. I'm happy for this to be merged 👍

[cbravobernal]

I just cherry-picked this PR to the release/17.6 branch to get it included in the next release: e14583d