Post Content: Update placeholder when editing template #58361
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: ramon <ramonjd@gmail.com>
noisysocks
added
[Type] Enhancement
|
Size Change: +176 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 3368838. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7703659623
|
|
I'm not a believer in this one. I regret to be the wet blanket here, but this seems an arbitrary placeholder to update, and I still don't think this will make a meaningful difference to the otherwise very legitimate issue. I think we need to look at a proper long term solution for 6.6, one that does not rely on outlines or placeholders or other noise that I worry will become vestigial and feel like bandaids we have to remove in the future. Instead we should focus on smaller improvements, like #58169, or the idea that clicking anywhere when the template and footer are locked, sets focus in the nearest editable field. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates the Post Content block's placeholder when viewing it in the context of editing a template.
I pulled this out of #57572. Props to my boy @ramonjd.
Why?
A common painpoint when using the site editor is that users delete the Post Content block without meaning to. We hope to reduce this by making it look more like placeholder content and less like actual content.
Testing Instructions