Block Hooks API: Update Navigation block feature gate

[tjcafferkey]

What?

Updates the feature gate for usage of the Block Hooks API to insert inner blocks into the core Navigation block.

Why?

We were previously checking for get_hooked_blocks to gate this feature against WordPress 6.3 and below, however this feature also depends upon the metadata ignoredHookedBlocks functionality to work correctly which isn't present within WordPress 6.4, resulting in a bug surfacing itself.

How?

I've updated the feature gate to check for the function responsible for the ignoredHookedBlocks logic that we need, which prevents this running on WP 6.4 until compat code is ported over.

Testing Instructions

On WP 6.4

1. Add the below code to your themes function file and check on the frontend and within the Editor that the Search block does not get inserted into your Navigation

On WP 6.5 Beta

1. Add the below code to your themes functions file to register the core/search block as an inner block
2. Load header template part, change the width of the Search block and save template part
3. Load frontend and check that only 1 Search block is rendered.

function register_navigation_last_child( $hooked_blocks, $position, $anchor_block, $context ) {
	if ( $anchor_block === 'core/navigation' && $position === 'last_child' ) {
		$hooked_blocks[] = 'core/search';
	}

	return $hooked_blocks;
}

add_filter( 'hooked_block_types', 'register_navigation_last_child', 10, 4 );

[ockham]

LGTM! Thank you!

[ockham]

@c4rl0sbr4v0 We'd like to include this in GB 17.6. Should we cherry-pick to the release/17.6 branch (after merging to trunk, of course), or would you prefer doing that yourself? 😊

(Edit: No need for a separate RC, IMO.)

[github-actions]

Flaky tests detected in d62993a.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7698726773
📝 Reported issues:

• [Flaky Test] User Mention: should insert two subsequent mentions #48569 in /test/e2e/specs/editor/various/autocomplete-and-mentions.spec.js

[cbravobernal]

Hi @ockham

With the label is enough, I will do a RC3 tomorrow (for other PRs 😅 ), not this one.

[cbravobernal]

I just cherry-picked this PR to the release/17.6 branch to get it included in the next release: 8a7d26b