Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfirmDialog: Add __next40pxDefaultSize to buttons #58421

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

t-hamano
Copy link
Contributor

@t-hamano t-hamano commented Jan 30, 2024

What?

This PR adds a __next40pxDefaultSize prop to make the two buttons inside the ConfirmDialog component 40px tall. As a result, the issue reported in #58374 will also be closed.

Before After
image image

Why?

Support the consistent component effort in #46734.

Also, for example, in the Site Editor's renameing modal, the button height is already 40px. By applying this PR, the height of the buttons in the rename/delete modal dialog will be unified.

image
image

Testing Instructions

@t-hamano t-hamano added [Type] Enhancement A suggestion for improvement. [Package] Components /packages/components labels Jan 30, 2024
@t-hamano t-hamano self-assigned this Jan 30, 2024
@t-hamano t-hamano requested a review from a team January 30, 2024 05:11
@t-hamano t-hamano marked this pull request as ready for review January 30, 2024 05:11
Copy link

Flaky tests detected in b43000e.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7706495986
📝 Reported issues:

Copy link
Member

@mirka mirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you! 🚀

@t-hamano t-hamano merged commit 7934adc into trunk Jan 30, 2024
59 checks passed
@t-hamano t-hamano deleted the confirm-dialog/40px-size branch January 30, 2024 11:19
@github-actions github-actions bot added this to the Gutenberg 17.7 milestone Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Font Library: Buttons within the Fonts modal dialog should use the new buttons height
2 participants