Block Bindings: Change core/pattern-attributes source for core/pattern-overrides
#58434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SantosGuillamot
added
[Feature] Synced Patterns
SantosGuillamot
requested review from
spacedmonkey,
kevin940726,
Mamaduka and
ajitbohra
as code owners
SantosGuillamot
added
the
Backport to Gutenberg RC
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/compat/wordpress-6.5/block-bindings/sources/pattern.php ❔ lib/compat/wordpress-6.5/block-bindings/sources/post-meta.php |
gziolo
reviewed
Jan 30, 2024
| array( | ||
| 'label' => __( 'Pattern Attributes' ), | ||
| 'label' => __( 'Pattern Overrides' ), |
There was a problem hiding this comment.
See the related comment WordPress/wordpress-develop#5888 (comment) in wordpress-develop about using _x.
Suggested change
| 'label' => __( 'Pattern Overrides' ), | |
| 'label' => _x( 'Pattern Overrides', 'block binding source' ), |
The same could get incorporated in other places where we use labels for this label and Post Meta.
|
Size Change: +120 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
gziolo
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Thank you for taking care of it.
By the way, we should apply the same changes to WordPress/wordpress-develop#5888.
gziolo
reviewed
Jan 30, 2024
| array( | ||
| 'label' => __( 'Pattern Attributes' ), | ||
| 'label' => _x( 'Pattern Overrides', 'Label for the block bindings source used for partially synced overrides' ), |
There was a problem hiding this comment.
The context param can be more concise, see existing usage:
There was a problem hiding this comment.
Oh, okay! I'll change that 🙂
|
Flaky tests detected in f3f8f78. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7711165451
|
SantosGuillamot
deleted the
update/change-patterns-overrides-source-name
branch
cbravobernal
pushed a commit
that referenced
this pull request
Jan 30, 2024
…tern-overrides` (#58434) * Change `pattern-attributes` for `pattern-overrides` * Use `_x()` function for translations * Add check in post meta source * Update pattern description * Update `_x( )` context to be more concise
|
I just cherry-picked this PR to the release/17.6 branch to get it included in the next release: 7936454 |
cbravobernal
removed
the
Backport to Gutenberg RC
youknowriad
pushed a commit
that referenced
this pull request
Jan 31, 2024
…tern-overrides` (#58434) * Change `pattern-attributes` for `pattern-overrides` * Use `_x()` function for translations * Add check in post meta source * Update pattern description * Update `_x( )` context to be more concise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
I'm renaming the
core/pattern-attributessource forcore/pattern-overridesas discussed here.I also took the opportunity to add a small check to the post meta source that was included in the WordPress backport: link and it was lacking in Gutenberg.
Why?
It seems to be more aligned with the current naming.
How?
Just search and replace.
Testing Instructions
Test pattern syncing overrides: