Try/admin color lighten colors #58481
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonjd
commented
Jan 31, 2024
| @@ -428,6 +428,14 @@ | |||
| // Hexadecimal css vars do not work in the rgba function. | |||
| --wp-admin-theme-color: #{$color-primary}; | |||
| --wp-admin-theme-color--rgb: #{hex-to-rgb($color-primary)}; | |||
|
|
|||
| // Lighter shades. | |||
There was a problem hiding this comment.
I'm thinking, the easier path forward would be to use rgba(var(--wp-admin-theme-color--rgb), 0.08) directly.
Example:
--wp-admin-theme-color-opaque-04:rgba(var(--wp-admin-theme-color--rgb), 0.04);
--wp-admin-theme-color-opaque-08:rgba(var(--wp-admin-theme-color--rgb), 0.08);This means no color changes, but the vars are a bit clunky.
ramonjd
added
[Type] Enhancement
This was referenced Jan 31, 2024
|
Size Change: +3.26 kB (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 1790cc3. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7719860858
|
|
cc @SaxonF since this may be captured by the Theme package work. |
Thanks for the link. Looks promising. I wouldn't want to introduce any new CSS vars here if they're going to create hurdles for a wider refactor. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @jameskoster. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core SVNIf you're a Core Committer, use this list when committing to GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is an experiment to replace (and standardize) adhoc admin color rgba "variations" with solid admin colors.
Example, replacing
rgba(var(--wp-admin-theme-color--rgb), ${ alpha_value } )withvar(--wp-admin-theme-color-lighter-${ lighten_value })Note
It's difficult to get exact matches of current
rgbavariations using SASS'slightenfunction. Notice how thergbacolors are greyer. This PR opts for thelightenfunction to complement thedarkencolor set, by assuming that the color palette will be more uniform.Where
--wp-admin-theme-color--rgb === 0, 124, 186:rgba(0, 124, 186, 0.08)rgb(242, 251, 255)rgba(0, 124, 186, 0.04)rgb(247, 252, 255)Example output:
Why?
To rein in random admin color alpha-variants, and allow better control over the color palette, color contrast ratios etc.
See related comments in:
How?
Use SASS's
lightenfunction to create admin-color CSS vars.Testing Instructions
Compare trunk with this branch for components that have changed:
In action:
Before
before.mp4
After
after.mp4