Font Library: Use Button's API to disable footer buttons #58529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Code Quality
|
Size Change: -5 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
ciampo
approved these changes
Feb 1, 2024
There was a problem hiding this comment.
LGTM 🚀
As you pointed out, the Button component already disables internally click events when disabled but focusable:
gutenberg/packages/components/src/button/index.tsx
Lines 178 to 192 in c87e338
Thank you for telling me that 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up: #58364
See this comment: #58364 (comment)
What?
This PR uses the
__experimentalIsFocusableanddisabledprops to disable the footer buttons of the font library.Why?
It makes more sense to use the component's API rather than using custom props.
How?
I also removed the conditional statement in the
onClickprop. Even in the whole project, when using__experimentalIsFocusableanddisabled, such conditional statements seem to be used very little.I would appreciate any advice on whether this change makes sense.
Testing Instructions
Please refer to the "Testing Instructions for Keyboard" section of #58364 to confirm that it still works as expected.