MediaReplaceFlow: restore popover width #58597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Regression
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core SVNIf you're a Core Committer, use this list when committing to GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -4 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in bc008c1. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7752218681
|
jasmussen
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
Seems to work in all the cases where it needs to:
Thanks for catching this.
A separate note for future link control work, it'd be nice to find an alternative to the hard-coded link control width, for example hard-coding the width of the text that needs to get elided instead, or the width of the main input field. This particular line seems prone to error.
|
@jasmussen Thanks for the review!
Yes, there should be a better solution in the future. For now, I would like to merge this PR to avoid shipping regressions to WP6.5. |
|
P.S. I added you as a co-author following this comment, but I can't seem to see your avatar on the commit 🤔
Probably you may want to add your WP.org email address to your GitHub account. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #58593
What?
This PR changes the width of the link control inside the
MediaReplaceFlowcomponent back from 200px to 300px.This allows you to remove unintended scrollbars.
Why?
This width was changed in #57608. #57608 focuses on improving the link UI, so this width change should be unintentional.
Testing Instructions