Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine when Props Bot runs #58616

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Refine when Props Bot runs #58616

merged 2 commits into from
Feb 2, 2024

Conversation

desrosj
Copy link
Contributor

@desrosj desrosj commented Feb 2, 2024

What?

This refines when Props Bot runs and leaves comments a bit.

Why?

There are some scenarios where it's not appropriate for the bot to collect a list of contributors.

How?

When a PR is a draft, or closed, the bot should not comment with a list of contributors.

Reported in #58576.

@desrosj desrosj self-assigned this Feb 2, 2024
Copy link

github-actions bot commented Feb 2, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core SVN

If you're a Core Committer, use this list when committing to wordpress-develop in SVN:

Props: desrosj, mamaduka.

GitHub Merge commits

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@desrosj desrosj marked this pull request as ready for review February 2, 2024 13:38
@desrosj
Copy link
Contributor Author

desrosj commented Feb 2, 2024

Because the pull_request_target event runs in the context of the base of the pull request, rather than in the context of the merge commit, we'll likely need to merge this to properly test.

@desrosj desrosj added the [Type] Project Management Meta-issues related to project management of Gutenberg label Feb 2, 2024
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick follow-up, @desrosj!

Let's give it a try :)

@desrosj desrosj merged commit 87689b3 into trunk Feb 2, 2024
58 of 62 checks passed
@desrosj desrosj deleted the fix/props-bot-closed-prs branch February 2, 2024 14:10
@github-actions github-actions bot added this to the Gutenberg 17.7 milestone Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Project Management Meta-issues related to project management of Gutenberg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants