Rich Text: Only apply focus to elements not selection #58745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
[Type] Bug
|
Size Change: +61 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 57ada55. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7804001278
|
|
Does this solve for the same test setup as shown in the original Issue? Loads of links all within the same paragraph. |
Yes |
jeryj
approved these changes
Feb 6, 2024
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Maybe @ellatrix can provide some insight? |
|
I think we should merge this as it fixes the bug. I'd still appreciate a review from someone who knows more about this than I do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
When handling focus events use the dom to handle.
This is an attempt to fix #58322.
Why?
I'm not totally sure what
__unstableDomOnlydoes yet. More investigation needed.How?
Pass
{ domOnly: true }toapplyRecord.We should add a test to verify the fix.
Testing Instructions
Screenshots or screencast
Feb-06-2024.17-56-10.mp4