Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style theme variations: add property extraction and merge utils #58803

Merged
merged 10 commits into from
Feb 13, 2024
Merged

Style theme variations: add property extraction and merge utils #58803

merged 10 commits into from
Feb 13, 2024

Commits on Feb 13, 2024

  1. First commit 

    Pulling out the utils from #56622 so we test separately
    @ramonjd
    ramonjd committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    d0a9d12 View commit details
    Browse the repository at this point in the history

  2. Adding failing tests :)

    @ramonjd
    ramonjd committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    73c62b9 View commit details
    Browse the repository at this point in the history

  3. Adds working tests 

    Removes extra functions - now internal to the hook
    @ramonjd
    ramonjd committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    e97054a View commit details
    Browse the repository at this point in the history

  4. Adds more tests

    @ramonjd
    ramonjd committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    28b1564 View commit details
    Browse the repository at this point in the history

  5. Adds filterObjectByProperty tests

    @ramonjd
    ramonjd committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    d80fa65 View commit details
    Browse the repository at this point in the history

  6. Update packages/edit-site/src/hooks/use-theme-style-variations/use-th… 

    …eme-style-variations-by-property.js

Co-authored-by: Andrew Serong <14988353+andrewserong@users.noreply.github.com>
    @ramonjd @andrewserong
    ramonjd and andrewserong committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    5fbca49 View commit details
    Browse the repository at this point in the history

  7. Merge map callbacks

    @ramonjd
    ramonjd committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    ee36d45 View commit details
    Browse the repository at this point in the history

  8. More tests, adding a null check too

    @ramonjd
    ramonjd committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    1ef39b8 View commit details
    Browse the repository at this point in the history

  9. Update comment to reflect functionality

    @ramonjd
    ramonjd committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    3fa7504 View commit details
    Browse the repository at this point in the history

  10. Update test to ensure we don't reference original object

    @ramonjd
    ramonjd committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    43c2cd3 View commit details
    Browse the repository at this point in the history