Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix mistake in viewScriptModule documentation #58815

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

sirreal
Copy link
Member

@sirreal sirreal commented Feb 8, 2024

What?

Fix a documentation mistake introduced in #58731.

Why?

Some copy/pasted documentation was not correctly updated.

You can see a duplicated "View script" section in the docs at the moment.

Thanks @gziolo for spotting it here WordPress/wordpress-develop#5860 (comment).

Copy link

github-actions bot commented Feb 8, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core SVN

Core Committers: Use this line as a base for the props when committing in SVN:

Props jonsurrell, cbravobernal.

GitHub Merge commits

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: sirreal <jonsurrell@git.wordpress.org>
Co-authored-by: c4rl0sbr4v0 <cbravobernal@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@sirreal sirreal added [Type] Bug An existing feature does not function as intended [Type] Developer Documentation Documentation for developers labels Feb 8, 2024
@sirreal sirreal enabled auto-merge (squash) February 8, 2024 10:11
@sirreal sirreal removed the [Type] Bug An existing feature does not function as intended label Feb 8, 2024
@gziolo gziolo disabled auto-merge February 8, 2024 10:31
@gziolo gziolo merged commit ca4c232 into trunk Feb 8, 2024
35 of 66 checks passed
@gziolo gziolo deleted the fix/view-script-module-docs branch February 8, 2024 10:31
@github-actions github-actions bot added this to the Gutenberg 17.7 milestone Feb 8, 2024
Copy link

github-actions bot commented Feb 8, 2024

Flaky tests detected in bc53abd.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7827950698
📝 Reported issues:

@desrosj
Copy link
Contributor

desrosj commented Feb 8, 2024

👋 Hi @gziolo! Just a friendly reminder to manually review, update as needed, and include the Co-authored-by trailers in the merge commit message. In case it was missed, here's the announcement post and the accompanying handbook page with the specific details.

If it was on accident, no big deal! But just trying to make sure everyone is aware as we retrain our brains. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants