Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules API: Script Modules add deregister option. #58830

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

cbravobernal
Copy link
Contributor

@cbravobernal cbravobernal commented Feb 8, 2024

What?

Syncs WordPress/wordpress-develop#6061 in Gutenberg, to be compatible with WordPress < 6.5
Updates the patch for loading Gutenberg Interactivity API script module instead of Core one.

Why?

Consistency with wp_deregister_style or wp_deregister_script. To be able to override script modules.

How?

Testing Instructions

Gutenberg version of Interactivity API should be loaded in WP 6.4, 6.5 with this PR merged.

@cbravobernal cbravobernal added the [Feature] Script Modules API Related to the Script Modules API that adds support for native ES modules and import maps label Feb 8, 2024
@cbravobernal cbravobernal self-assigned this Feb 8, 2024
Copy link

github-actions bot commented Feb 8, 2024

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ lib/interactivity-api.php
❔ lib/compat/wordpress-6.5/class-wp-script-modules.php
❔ lib/compat/wordpress-6.5/scripts-modules.php
❔ lib/load.php

@cbravobernal cbravobernal force-pushed the add/script-modules-add-deregister branch from 5c1a8f5 to 1d71612 Compare February 15, 2024 15:22
Copy link

Flaky tests detected in 1d71612.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7918228996
📝 Reported issues:

@cbravobernal cbravobernal marked this pull request as ready for review February 15, 2024 21:06
Copy link

github-actions bot commented Feb 15, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: c4rl0sbr4v0 <cbravobernal@git.wordpress.org>
Co-authored-by: westonruter <westonruter@git.wordpress.org>
Co-authored-by: SantosGuillamot <santosguillamot@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SantosGuillamot
Copy link
Contributor

Do we need a backport label for this PR?

@swissspidy
Copy link
Member

Do we need a backport label for this PR?

No, because this brings a change from core to Gutenberg.

@gziolo gziolo added the Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core label Feb 19, 2024
Copy link

github-actions bot commented Feb 19, 2024

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
  • Labels found: [Type] Enhancement, Backport from WordPress Core, [Feature] Script Modules API.

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

@gziolo gziolo merged commit b0aa007 into trunk Feb 19, 2024
66 of 69 checks passed
@gziolo gziolo deleted the add/script-modules-add-deregister branch February 19, 2024 08:23
@github-actions github-actions bot added this to the Gutenberg 17.8 milestone Feb 19, 2024
@youknowriad youknowriad added the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Feb 20, 2024
@youknowriad
Copy link
Contributor

I've added the backport label to make sure this code is also in wp/6.5 branch.

getdave pushed a commit that referenced this pull request Feb 20, 2024
* Add deregister module function

* Sync with core PR
@getdave
Copy link
Contributor

getdave commented Feb 20, 2024

I just cherry-picked this PR to the cherry-pick-beta-2 branch to get it included in the next release: 1605148

@getdave getdave removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Feb 20, 2024
youknowriad pushed a commit that referenced this pull request Feb 20, 2024
* Add deregister module function

* Sync with core PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core [Feature] Script Modules API Related to the Script Modules API that adds support for native ES modules and import maps [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants