Try fixing flaky 'inserting blocks' e2e tests #58848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
the
[Type] Automated Testing
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 1.71 MB ℹ️ View Unchanged
|
t-hamano
reviewed
Feb 9, 2024
There was a problem hiding this comment.
Thanks for the PR!
Moving from the focused post title field to the editor canvas using the
Enterkey failed, so I replaced it with the default block appender click action.
Is the instability caused by the Enter key being pressed before the post title is focused? If so, does it make sense to check focus before pressing Enter?
gutenberg/test/e2e/specs/editor/plugins/nonce.spec.js
Lines 17 to 22 in 93d417b
Or, if we switch to the approach of clicking the default block inserter instead of pressing Enter, the implicit test for "When pressing Enter on a post title, creates an empty paragraph block and moves focus" might lost.
As far as I can see, this is not explicitly tested, so what do you think about adding this test?
Correct. These tests aren't about the post-title field, so it doesn't matter how we insert blocks.
If it's not already covered by post-title specs, then yes, we should add it. |
t-hamano
approved these changes
Feb 9, 2024
|
Thank you, Aki! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #41477.
Fixes #40301.
Fixes #35280.
Fixes #45332.
PR tries to fix a few flaky tests in the
inserting blockssuite.How?
Enterkey failed, so I replaced it with the default block appender click action.Browse all#45332 - for a brief moment, two inserters can be on the page, and the locator strick check will fail. I've added context to the locators. Similar to Block inserter search e2e test: scope list item lookup to the inserter panel #47066.Testing Instructions
Screenshots