Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Bindings: enhance block attribute binding to external sources #58895

Closed
wants to merge 74 commits into from
Closed

Block Bindings: enhance block attribute binding to external sources #58895

wants to merge 74 commits into from

Commits on Feb 27, 2024

  1. replace use-binding-attributes with block-binding-support

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    e9a1ddf View commit details
    Browse the repository at this point in the history

  2. minor enhancement

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    8c20db3 View commit details
    Browse the repository at this point in the history

  3. minor change

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    31c1bec View commit details
    Browse the repository at this point in the history

  4. tweak

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    8a8a839 View commit details
    Browse the repository at this point in the history

  5. do not import use-binding-attributes

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    39b7a89 View commit details
    Browse the repository at this point in the history

  6. use isItPossibleToBindBlock() helper

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    9f643e7 View commit details
    Browse the repository at this point in the history

  7. introduce core/entity source handler

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    f89fc68 View commit details
    Browse the repository at this point in the history

  8. rename folder

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    8ef5a5b View commit details
    Browse the repository at this point in the history

  9. rename source name

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    b5a86ac View commit details
    Browse the repository at this point in the history

  10. polish post-entity source handler

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    71e716c View commit details
    Browse the repository at this point in the history

  11. make core/post-entity more consistent with core-data

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    12d5cd4 View commit details
    Browse the repository at this point in the history

  12. make entity source hand;ler more generic

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    ebb9bb2 View commit details
    Browse the repository at this point in the history

  13. fix entity sour handl;er issues

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    1470818 View commit details
    Browse the repository at this point in the history

  14. remove uneeded useValue () hook (crossfingers)

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    64eedc2 View commit details
    Browse the repository at this point in the history

  15. minor jsdoc improvement

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    a2d5cb2 View commit details
    Browse the repository at this point in the history

  16. clean

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    4deda60 View commit details
    Browse the repository at this point in the history

  17. rename with updateValue()

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    2510322 View commit details
    Browse the repository at this point in the history

  18. remove core/entity binding source handler

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    fce8539 View commit details
    Browse the repository at this point in the history

  19. move useSource to Connector cmp

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    8d71311 View commit details
    Browse the repository at this point in the history

  20. move the whole dryining logic to the Connect component

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    411ede8 View commit details
    Browse the repository at this point in the history

  21. improve jsdoc

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    eb7e032 View commit details
    Browse the repository at this point in the history

  22. rename to blockProps

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    b8a9061 View commit details
    Browse the repository at this point in the history

  23. minor jsdoc improvements

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    2ae62f0 View commit details
    Browse the repository at this point in the history

  24. use a single effect to update attr and value

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    cc21a16 View commit details
    Browse the repository at this point in the history

  25. discard useValue. Return value and setValue instead

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    396dfb3 View commit details
    Browse the repository at this point in the history

  26. check wheter updateValue function is defined

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    f25f9b8 View commit details
    Browse the repository at this point in the history

  27. check prop value is defined when updating attr

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    f3b3e05 View commit details
    Browse the repository at this point in the history

  28. handle placerholder

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    56ae182 View commit details
    Browse the repository at this point in the history

  29. ensure to put attribute in sync when onmount

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    7de80c3 View commit details
    Browse the repository at this point in the history

  30. remove // eslint comment

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    8866135 View commit details
    Browse the repository at this point in the history

  31. enable editing for bound with post-meta

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    42ed184 View commit details
    Browse the repository at this point in the history

  32. move block bindiung processor to hooks/

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    60e73d4 View commit details
    Browse the repository at this point in the history

  33. ensure update bound attr once when mounting

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    3c9a341 View commit details
    Browse the repository at this point in the history

  34. Update packages/block-editor/src/hooks/block-binding-support/index.js 

    Co-authored-by: Michal <mmczaplinski@gmail.com>
    @retrofox @michalczaplinski
    retrofox and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    7263d22 View commit details
    Browse the repository at this point in the history

  35. disable editing block attribute

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    d5b5e78 View commit details
    Browse the repository at this point in the history

  36. move changes to the use-binding-attributes file

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    7268a55 View commit details
    Browse the repository at this point in the history

  37. introduce BlockBindingBridge component

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    10b7765 View commit details
    Browse the repository at this point in the history

  38. update isItPossibleToBindBlock() import path

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    472d01e View commit details
    Browse the repository at this point in the history

  39. introduce hasPossibleBlockBinding() helper

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    37c6ab9 View commit details
    Browse the repository at this point in the history

  40. use hooks API to extened blocks with bound attts

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    eab050b View commit details
    Browse the repository at this point in the history

  41. fix propagating attr value. jsdoc

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    de04130 View commit details
    Browse the repository at this point in the history

  42. minor changes

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    28eb168 View commit details
    Browse the repository at this point in the history

  43. minor code enhancement

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    fcc5b8a View commit details
    Browse the repository at this point in the history

  44. not edit bound prop for now

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    cb9e380 View commit details
    Browse the repository at this point in the history

  45. jsdoc

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    bd9cf18 View commit details
    Browse the repository at this point in the history

  46. revert using hooks API to extrend block

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    7ecfab9 View commit details
    Browse the repository at this point in the history

  47. jsdoc

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    ed16267 View commit details
    Browse the repository at this point in the history

  48. update internal path

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    dbf70e5 View commit details
    Browse the repository at this point in the history

  49. rollback hook utils chnages

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    8bb843d View commit details
    Browse the repository at this point in the history

  50. tidy

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    1abf420 View commit details
    Browse the repository at this point in the history

  51. wrap Connector instances with a Fragment

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    ef40bd4 View commit details
    Browse the repository at this point in the history

  52. return original Edit instance when no bindings

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    ca54c3f View commit details
    Browse the repository at this point in the history

  53. check whether useSource is defined

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    bfde100 View commit details
    Browse the repository at this point in the history

  54. Use useSelect and move it out of the for loop

    @michalczaplinski
    michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    9aedf87 View commit details
    Browse the repository at this point in the history

  55. check attr value type

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    dd77b7c View commit details
    Browse the repository at this point in the history

  56. iterare when creating BindingConnector instances

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    b17ce14 View commit details
    Browse the repository at this point in the history

  57. rename helper functions

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    74b32ad View commit details
    Browse the repository at this point in the history

  58. use useSelect to get binding sources

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    93430da View commit details
    Browse the repository at this point in the history

  59. Update packages/block-editor/src/hooks/use-bindings-attributes.js 

    Co-authored-by: Michal <mmczaplinski@gmail.com>
    @retrofox @michalczaplinski
    retrofox and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    ecaf10a View commit details
    Browse the repository at this point in the history

  60. Update packages/block-editor/src/hooks/use-bindings-attributes.js 

    Co-authored-by: Michal <mmczaplinski@gmail.com>
    @retrofox @michalczaplinski
    retrofox and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    2fd9911 View commit details
    Browse the repository at this point in the history

  61. pass prev attr value to compare

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    5bd3a79 View commit details
    Browse the repository at this point in the history

  62. improve binding allowed block attributes

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    1741497 View commit details
    Browse the repository at this point in the history

  63. sync derevied updates when updating bound attr

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    e435a3d View commit details
    Browse the repository at this point in the history

  64. improve getting attr source

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    8f27c48 View commit details
    Browse the repository at this point in the history

  65. check properly bindings data

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    3d953f8 View commit details
    Browse the repository at this point in the history

  66. preserve the RichTextData for block attr

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    3d106ce View commit details
    Browse the repository at this point in the history

  67. comment line just for tesrting purposes

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    994bed1 View commit details
    Browse the repository at this point in the history

  68. rebasing changes

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    4998315 View commit details
    Browse the repository at this point in the history

  69. rollback change foir testing purposes

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    9072e6a View commit details
    Browse the repository at this point in the history

  70. change cmp prop name. improve jsdoc

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    2133393 View commit details
    Browse the repository at this point in the history

  71. simplify checking bindins value

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    91f64d6 View commit details
    Browse the repository at this point in the history

  72. use attr name as key instance

    @retrofox @michalczaplinski
    retrofox authored and michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    987fb58 View commit details
    Browse the repository at this point in the history

  73. Refactor useMarkPersistent function

    @michalczaplinski
    michalczaplinski committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    db32d18 View commit details
    Browse the repository at this point in the history

  74. pick block data from straight props

    @retrofox
    retrofox committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    e55f6bc View commit details
    Browse the repository at this point in the history