Site Editor: Tweak save hub button #58917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Enhancement
|
Size Change: +15 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
@SaxonF Thanks for the review! |
|
Apologies for being late to this. On a consistency perspective, a trade-off was not considered here, which is that in the resting state which you see most of the time, the alignment will be wrong:
I understand the balance: that when the primary save button transforms into the disabled "saved" state, it's awkward that the text moves to the left. I think there are more general improvements we can look at, in that flow, to address it, including potentially reducing the prominence of the "Saved" state, adding some fades or otherwise. But keeping it centered makes things look out of alignment most of the time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #46734
What?
This PR makes the following changes to the save button at the bottom left of the site editor:
Why?
This button is a common component (
SaveButton) that is also used in the header, and the component itself hassize="compact". So even if you give it the__next40pxDefaultSizeprop and use this component, it might end up being 32px tall instead of 40px.Also, this component should expect the text to be horizontally centered. However, if this component is disabled, i.e. has a check icon, the Button component's selector for left-aligning text is more specific, as shown below, overriding the left-right center style.
How?
sizeprop that was hard-coded in theSaveButtoncomponent is received as a component prop.Testing Instructions