Editor: Hide template part and post content blocks in some site editor contexts #58928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -1.27 kB (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
youknowriad
force-pushed
the
update/hide-post-content-template-part-blocks
branch
from
b029242
to
ec052bb
Compare
aaronrobertshaw
approved these changes
Feb 15, 2024
| export function useHideBlocksFromInserter( postType ) { | ||
| useEffect( () => { | ||
| /* | ||
| * Prevent adding template part in the post editor. |
There was a problem hiding this comment.
Suggested change
| * Prevent adding template part in the post editor. | |
| * Prevent adding template part in the editor. |
Nit: Now this prevention is across both the post and site editors, is it worth making this comment a little more generic and not reference the post editor specifically?
Same for the other filter comment below.
|
Thanks for testing so quickly @aaronrobertshaw Work well for me in both post and site editors 👍🏻 In "edit template" mode for posts in both editors, I can add template parts, as well as post content block. |
|
Flaky tests detected in 9ad5632. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7913743091
|
youknowriad
deleted the
update/hide-post-content-template-part-blocks
branch
Kinda thinking in addition to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #52632
What?
In the post editor, we hide the "post content" block and the "template part" blocks in the default mode. But in the site editor, we also have the same modes but we don't do anything for these blocks, we just keep them around. This PR unifies that by moving this logic to the EditorProvider.
I think the existence of these filters is an indication that we're lacking some block API to define in which contexts (postTypes?) these blocks are allowed or not. That said, it's not entirely clear what such API should look like.
I also think the "template locked" mode should have the same treatment because you can't insert blocks outside post content there as well.
Testing Instructions
Try inserting "content" or "header" within posts or pages (either in post or site editors), you shouldn't be able to find these blocks in the inserter.