Inserter: Don't select the closest block with 'disabled' editing mode #58971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +17 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
Mamaduka
force-pushed
the
fix/insertion-point-disabled-block
branch
from
ea8f29f
to
769f2e5
Compare
|
Flaky tests detected in 769f2e5. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7891851702
|
|
Is this meant to be backported to 6.5? |
|
I think it would be good addition to the block editing fixes and enhancements. |
youknowriad
added
the
Backport to WP 6.7 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Feb 20, 2024
…abled (#58971) Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: noisysocks <noisysocks@git.wordpress.org> Co-authored-by: dernin <dernin@git.wordpress.org>
|
I just cherry-picked this PR to the more/backports-for-beta3 branch to get it included in the next release: 0f3e9fb |
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
youknowriad
added
the
Backported to WP Core
youknowriad
pushed a commit
that referenced
this pull request
Feb 20, 2024
…abled (#58971) Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: noisysocks <noisysocks@git.wordpress.org> Co-authored-by: dernin <dernin@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #57227.
PR updates the
onClickhandler for theInbetweenInsertionPointPopovercomponent to only select the closest block if it has editing mode enabled.Why?
Users shouldn't be able to select the disabled blocks.
Testing Instructions
Snippet
Testing Instructions for Keyboard
Same.
Screenshots or screencast
Before
CleanShot.2024-02-01.at.10.08.53.mp4
After
CleanShot.2024-02-13.at.18.33.42.mp4