-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor: Do not open list view by default on mobile #59016
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: -87 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
Flaky tests detected in 9e3a47e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7913375204
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That works for me, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tests as advertised for me ✅
I left a minor nit in a comment but other than that, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 this is a nice improvement, thanks for fixing it up!
In what may be a very rare scenario, if I follow the steps below, the list view will not be displayed by default.
Is it not possible to use a Also, although this may be outside the scope of this PR, I thought it would be nice to have a process to hide the list view when switching from desktop view to mobile view. |
I think personally resizing viewport is not something users do while using an app in general, so I don't think it's something to really account for. |
Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Note that as part of curating the Gutenberg 17.8 changelog, I added the label [Feature] List View to this PR to better categorize it. Please let me know if there is a different label that would be a better fit. |
What?
In the editor (post and site) we have a preference that indicates whether we should open the list view by default or not.
In some very small viewport the list view button is not even available so taking this preference into consideration in smaller viewports doesn't make sense.
This PR makes this preference only work for desktops.
Testing Instructions
1- Check the "open list view by default" preference
2- Open the editor on mobile
3- The list view shouldn't be open by default.