Interactivity API: Only add proxies to plain objects inside the store #59039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbravobernal
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
DAreRodz
reviewed
Feb 19, 2024
|
Flaky tests detected in 2185920. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7976098141
|
cbravobernal
force-pushed
the
fix/interactivity-only-proxify-plain-objects
branch
from
7a8902e
to
2280d68
Compare
This was referenced Feb 20, 2024
cbravobernal
requested review from
kevin940726,
Mamaduka,
ntwb,
nerrad and
ajitbohra
as code owners
DAreRodz
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
I have simplified the code a bit and added a simple test with @c4rl0sbr4v0.
LGTM!
PS: Adding more tests related to the store would be great. We can do that in another PR, sooner than later.
DAreRodz
added
Backport to WP 6.7 Beta/RC
|
Size Change: -104 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
DAreRodz
changed the title
cbravobernal
deleted the
fix/interactivity-only-proxify-plain-objects
branch
getdave
pushed a commit
that referenced
this pull request
Feb 27, 2024
…#59039) * Only proxify plain objects * Do not support objects without prototypes * Rename store-tag to interactivity-data * Add test for non-plain objects in state * Update `isObject` implementation * Update changelog --------- Co-authored-by: c4rl0sbr4v0 <cbravobernal@git.wordpress.org> Co-authored-by: DAreRodz <darerodz@git.wordpress.org>
9 tasks
getdave
added
Backported to WP Core
getdave
pushed a commit
that referenced
this pull request
Feb 27, 2024
…#59039) * Only proxify plain objects * Do not support objects without prototypes * Rename store-tag to interactivity-data * Add test for non-plain objects in state * Update `isObject` implementation * Update changelog --------- Co-authored-by: c4rl0sbr4v0 <cbravobernal@git.wordpress.org> Co-authored-by: DAreRodz <darerodz@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Refactor the isObject function to only accept plain objects as stores.
Why?
Before this PR, the code was only checking with
typeof. In JavaScript, almost everything is an Object. We want to make sure that only plain objects are proxified. (Proxify means to add a getter that handles the namespace of the block/plugin and the Scope).