Framework: Optimize block validation attribute testing #5911
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #5897
This pull request seeks to optimize the block validator, specifically in its handling of attributes, replacing use of
Array
withSet
, where lookup viaSet#has
is many magnitudes more performant thanArray#indexOf
(~4x faster with CoreJS shim, ~9x faster natively). To my surprise while testing, I was not aware thatSet
is supported in IE11. Our build process still applies CoreJS, though I'm unsure if it is applied as a proper shim (when not already present in environment). In any case, a further step may be to drop this, though this should probably already be handled viababel-preset-env
.Testing instructions:
Verify that tests pass, and there are no regressions in the behavior of block validation (including invalidation), particularly affecting "meaningful attributes" (boolean attributes like
disabled
or enumerated attributes likecontenteditable="true"
).