[RNMobile] Remove opacity change when images are being uploaded #59264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekblank
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 1.7 MB ℹ️ View Unchanged
|
|
Flaky tests detected in f571d1e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7999972818
|
SiobhyB
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
Thank you for these changes, Derek! I tested on both iOS and Android, both work as expected. 🎉
Upload multiple images to a Gallery block on iOS:
Screen.Recording.2024-02-22.at.14.40.14.mov
Replacing a current image in an Image block on iOS:
Screen.Recording.2024-02-22.at.14.46.50.mov
I know there have been separate discussions about removing the opacity for other media-based blocks, including the cover, file, and video blocks. I agree that'd be great to remove the opacity from those, whether in this PR or a separate one. I'll go ahead to approve this one but happy to take another look if you want to expand its focus to include those other blocks, too.
|
Thanks for the review! I'll make a note to review the opacity behavior for other blocks. I know several of the media blocks do not implement a local media preview while the media is uploading -- a static placeholder is displayed instead. The opacity change may be unique to the Image block. |
4 tasks
dcalhoun
added a commit
to wordpress-mobile/test-cases
that referenced
this pull request
Jul 30, 2024
In-progress uploads no longer dim the image. This was removed in WordPress/gutenberg#59264.
dcalhoun
added a commit
to wordpress-mobile/test-cases
that referenced
this pull request
Jul 30, 2024
In-progress uploads no longer dim the image. This was removed in WordPress/gutenberg#59264.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removes opacity change when Images are uploaded.
Why?
As part of ongoing efforts to improve the media upload experience, we have received feedback that Image upload process could be improved by modifying an "in progress" state when uploading Images.
How?
In the current production app, an Image will appear at 0.3 opacity while uploading, and transitions to 100% visibility when the upload is successful.
This PR removes the animation and associated code references when Images transition from local media to network media.
Testing Instructions
Screenshots or screencast
Example Video
Screen_Recording_20240222_132358_Jetpack.Pre-Alpha.mp4