Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactivity API Docs: Update image with WordPress Make Core source #59281

Merged
merged 4 commits into from
Feb 22, 2024

Conversation

cbravobernal
Copy link
Contributor

What?

Update API Reference docs to use the Github uploaded image instead of the relative URL.

Why?

Cause we have a broken image in the Handbook 😢
Screenshot 2024-02-22 at 16 58 13

@cbravobernal cbravobernal added [Type] Developer Documentation Documentation for developers [Packages] Interactivity /packages/interactivity labels Feb 22, 2024
@cbravobernal cbravobernal self-assigned this Feb 22, 2024
@cbravobernal cbravobernal changed the title Update image with github source Interactivity API Docs: Update image with Github source Feb 22, 2024
Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh yeah these are always the worse. I cannot remember which format is the correct one.

It would be cool to catch this in CI somehow

@cbravobernal cbravobernal force-pushed the fix/docs-interactivity-api-reference-image branch from 2e7b323 to 3e0972b Compare February 22, 2024 16:12
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: c4rl0sbr4v0 <cbravobernal@git.wordpress.org>
Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@cbravobernal cbravobernal enabled auto-merge (squash) February 22, 2024 16:16
@cbravobernal
Copy link
Contributor Author

I finally moved the image to Make Core

Same as other docs:

![Paragraph block inspector](https://make.wordpress.org/core/files/2020/08/paragraph-block-inspector.png)

Copy link

Flaky tests detected in 8cb2396.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8007573256
📝 Reported issues:

@cbravobernal cbravobernal merged commit dc364b4 into trunk Feb 22, 2024
56 checks passed
@cbravobernal cbravobernal deleted the fix/docs-interactivity-api-reference-image branch February 22, 2024 16:46
@github-actions github-actions bot added this to the Gutenberg 17.9 milestone Feb 22, 2024
@cbravobernal cbravobernal changed the title Interactivity API Docs: Update image with Github source Interactivity API Docs: Update image with WordPress Make Core source Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Packages] Interactivity /packages/interactivity [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants